Issue 2893223002: [Interpreter] No need to read/return a value in GeneratorClose.

Issue 2893223002: [Interpreter] No need to read/return a value in GeneratorClose. (Closed)

Created:
3 years, 7 months ago by mvstanton

Modified:
3 years, 7 months ago

Reviewers:
rmcilroy

CC:
v8-reviews_googlegroups.com, rmcilroy

Target Ref:
refs/heads/master

Project:
v8

Visibility:
Public.

[Interpreter] No need to read/return a value in GeneratorClose. An oversight in Friday's CL. Thx to neis@chromium.org for the tip! BUG=v8:6351 TBR=rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2893223002 Cr-Commit-Position: refs/heads/master@{#45444} Committed: https://chromium.googlesource.com/v8/v8/+/0fb167d45d6e99c037a8a11ce212a47e764751ff

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	src/interpreter/interpreter-intrinsics-generator.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 8 (5 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893223002/1

3 years, 7 months ago (2017-05-22 07:54:39 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/0fb167d45d6e99c037a8a11ce212a47e764751ff

3 years, 7 months ago (2017-05-22 08:23:24 UTC) #7

Message was sent while issue was closed.

lgtm