Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 289313004: Add test data for dynamic CLD. (Closed)

Created:
6 years, 7 months ago by Andrew Hayden (chromium.org)
Modified:
6 years, 7 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add test data for dynamic CLD. This is necessary in order to allow browser tests to run correctly when using CLD in dynamic mode (either from an external file or via the component updater). This change is being split apart from the actual tests that use it because the CLD data file is too large to commit via the CQ and, as a result, must be dcommit'ed. BUG=367239 R=rmcilroy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271372

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, --1 lines) Patch
A chrome/test/data/cld2_component/160/_platform_specific/all/cld2_data.bin View Binary file 0 comments Download
A + chrome/test/data/cld2_component/160/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/cld2_component/README.chromium View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rmcilroy
lgtm, modulo a couple of nits. https://codereview.chromium.org/289313004/diff/1/chrome/test/data/cld2_component/README.chromium File chrome/test/data/cld2_component/README.chromium (right): https://codereview.chromium.org/289313004/diff/1/chrome/test/data/cld2_component/README.chromium#newcode9 chrome/test/data/cld2_component/README.chromium:9: revision 160 onwards, ...
6 years, 7 months ago (2014-05-19 13:16:02 UTC) #1
Andrew Hayden (chromium.org)
6 years, 7 months ago (2014-05-19 13:35:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r271372 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698