Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8766)

Unified Diff: chrome/test/data/cld2_component/README.chromium

Issue 289313004: Add test data for dynamic CLD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/cld2_component/160/manifest.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/cld2_component/README.chromium
diff --git a/chrome/test/data/cld2_component/README.chromium b/chrome/test/data/cld2_component/README.chromium
new file mode 100644
index 0000000000000000000000000000000000000000..bae374e7f2187d0256fd6d22f7ad598052ae2e01
--- /dev/null
+++ b/chrome/test/data/cld2_component/README.chromium
@@ -0,0 +1,25 @@
+This directory contains a static copy of the contents of the CLD2 CRX file.
+The ID of the extension (as well as other relevant information) can be found
+in the following file:
+ src/chrome/browser/component_updater/cld_component_installer.cc
+
+In general there should be little need to modify the data here. CLD2 updates
+are rare and consist of incremental improvements to language detection
+accuracy. All such updates are expected to be backwards-compatible from CLD2
+revision 160 onwards, which was the initial version to be checked in. Any
+future format-breaking changes are likely to result in a "CLD3".
+
+For the sake of maintainability and clarity of purpose, the subdirectory that
+contains the CRX extract is named for the version that is contained within it.
+This mimics the behavior of the component updater and makes it obvious at a
+glance which version of the CRX is checked in here; if you DO update the
+content here, make sure to make a new directory and update the constant in the
+test utilities class:
+ src/chrome/browser/translate/translate_browser_test_utils.cc
+
+If backwards compatibility is required, you'll have to add tests to try with
+both the old version and the new.
+
+For more information please refer to:
+ src/third_party/cld_2/README.chromium
+
« no previous file with comments | « chrome/test/data/cld2_component/160/manifest.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698