third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js - Issue 2893073002: DevTools: introduce ResourceMapping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

Issue 2893073002: DevTools: introduce ResourceMapping (Closed)

Patch Set: address comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js ('K') | « third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js ('k') | third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js » ('j') | third_party/WebKit/Source/devtools/front_end/bindings/ResourceBinding.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js b/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

index 2c238dd94a53062f444f88b5395b81b8c7fe13d2..b9b54def682134467592d43db22c3e3f31f4aa34 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

@@ -304,6 +304,7 @@ Bindings.DebuggerWorkspaceBinding.ModelData = class {

var uiLocation = null;

uiLocation = uiLocation || this._compilerMapping.rawLocationToUILocation(rawLocation);

uiLocation = uiLocation || this._resourceMapping.rawLocationToUILocation(rawLocation);

+ uiLocation = uiLocation || Bindings.resourceBindingManager.jsLocationToUILocation(rawLocation);

uiLocation = uiLocation || this._defaultMapping.rawLocationToUILocation(rawLocation);

return /** @type {!Workspace.UILocation} */ (uiLocation);

}

@@ -319,6 +320,8 @@ Bindings.DebuggerWorkspaceBinding.ModelData = class {

rawLocation = rawLocation || this._compilerMapping.uiLocationToRawLocation(uiSourceCode, lineNumber, columnNumber);

rawLocation = rawLocation || this._resourceMapping.uiLocationToRawLocation(uiSourceCode, lineNumber, columnNumber);

rawLocation = rawLocation || this._defaultMapping.uiLocationToRawLocation(uiSourceCode, lineNumber, columnNumber);

+ rawLocation =

+ rawLocation || this._debuggerModel.createRawLocationByURL(uiSourceCode.url(), lineNumber, columnNumber);

lushnikov 2017/06/12 23:17:53 dgozman: move this to ResourceBinding

lushnikov 2017/06/13 00:49:13 Done.

return rawLocation;

}