Issue 289303003: [Metrics] Move ExternalMetrics ownership to ChromeBrowserMainPartsChromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 289303003: [Metrics] Move ExternalMetrics ownership to ChromeBrowserMainPartsChromeos (Closed)

Created:
6 years, 7 months ago by Ilya Sherman

Modified:
6 years, 7 months ago

Reviewers:
xiyuan, Alexei Svitkine (slow)

CC:
chromium-reviews, jar (doing other things), stevenjb+watch_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org, Ilya Sherman, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, blundell

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Metrics] Move ExternalMetrics ownership to ChromeBrowserMainPartsChromeos BUG=374215 TEST=compiles R=asvitkine@chromium.org, xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271441

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -20 lines)			Patch
M	chrome/browser/chromeos/chrome_browser_main_chromeos.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/metrics/metrics_service.h	View	3 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/metrics/metrics_service.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/289303003/1

6 years, 7 months ago (2014-05-19 16:23:15 UTC) #6

Message was sent while issue was closed.

Change committed as 271441

Expand Messages | Collapse Messages