Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: chrome/browser/metrics/metrics_service.h

Issue 289303003: [Metrics] Move ExternalMetrics ownership to ChromeBrowserMainPartsChromeos (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/chrome_browser_main_chromeos.cc ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service.h
diff --git a/chrome/browser/metrics/metrics_service.h b/chrome/browser/metrics/metrics_service.h
index 9a52d030de221a0be1d42ef921d280c8967ef13e..d221ceb43f1c406b8a0f15fd1fdb026e8abd20bd 100644
--- a/chrome/browser/metrics/metrics_service.h
+++ b/chrome/browser/metrics/metrics_service.h
@@ -35,8 +35,6 @@
#if defined(OS_ANDROID)
#include "chrome/browser/android/activity_type_ids.h"
-#elif defined(OS_CHROMEOS)
-#include "chrome/browser/chromeos/external_metrics.h"
#endif
class ChromeBrowserMetricsServiceObserver;
@@ -255,10 +253,6 @@ class MetricsService
#endif // OS_WIN
#if defined(OS_CHROMEOS)
- // Start the external metrics service, which collects metrics from Chrome OS
- // and passes them to UMA.
- void StartExternalMetrics();
-
// Records a Chrome OS crash.
void LogChromeOSCrash(const std::string &crash_type);
#endif
@@ -573,11 +567,6 @@ class MetricsService
// Number of async histogram fetch requests in progress.
int num_async_histogram_fetches_in_progress_;
-#if defined(OS_CHROMEOS)
- // The external metric service is used to log ChromeOS UMA events.
- scoped_refptr<chromeos::ExternalMetrics> external_metrics_;
-#endif
-
// Stores the time of the first call to |GetUptimes()|.
base::TimeTicks first_updated_time_;
« no previous file with comments | « chrome/browser/chromeos/chrome_browser_main_chromeos.cc ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698