Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: ash/shell.cc

Issue 2892983002: Destroy NightLightController before PrefService (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shell.cc
diff --git a/ash/shell.cc b/ash/shell.cc
index 72fac6a55ab24a15cab0393890a9edc6d0f2c3a1..754d5e5c9774bfbfbf4a77bfe35ead20a50844ed 100644
--- a/ash/shell.cc
+++ b/ash/shell.cc
@@ -785,6 +785,9 @@ Shell::~Shell() {
shell_port_.reset();
session_controller_->RemoveObserver(this);
wallpaper_delegate_.reset();
+ // NightLightController depeneds on the PrefService and must be destructed
+ // before it. crbug.com/724231.
+ night_light_controller_ = nullptr;
pref_service_ = nullptr;
shell_delegate_.reset();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698