Destroy NightLightController before PrefService

Destroy NightLightController before PrefService

NightLightController depends on the PrefService to read and write
user prefs related to NightLight. It uses a PrefChangeRegistrar to
observe changes to those prefs. PrefChangeRegistrar is not expected
to outlive the PrefService, and hence must be destroyed first.

BUG=724231
TEST=Start chrome with --mash and expects to see no crashes
NightLightController when Shell is destroyed.

Review-Url: https://codereview.chromium.org/2892983002
Cr-Commit-Position: refs/heads/master@{#473375}
Committed: https://chromium.googlesource.com/chromium/src/+/21501560f5074b5e07c397fedc09d47a0a6c5b3f

[afakhry, 2017-05-19 17:24:35]

afakhry@chromium.org changed reviewers:
+ sky@chromium.org

[afakhry, 2017-05-19 17:24:36]

Sky, please take a look. Thank you.

[sky, 2017-05-19 20:01:35]

LGTM

[afakhry, 2017-05-19 21:44:38]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2017-05-19 21:45:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 22:52:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495230278979250, "parent_rev":
"bf85ac4f08f6420db9fbdd1fd91d2352fdae93de", "commit_rev":
"21501560f5074b5e07c397fedc09d47a0a6c5b3f"}

[commit-bot: I haz the power, 2017-05-19 22:53:06]

Description was changed from

==========
Destroy NightLightController before PrefService

NightLightController depends on the PrefService to read and write
user prefs related to NightLight. It uses a PrefChangeRegistrar to
observe changes to those prefs. PrefChangeRegistrar is not expected
to outlive the PrefService, and hence must be destroyed first.

BUG=724231
TEST=Start chrome with --mash and expects to see no crashes
NightLightController when Shell is destroyed.
==========

to

==========
Destroy NightLightController before PrefService

NightLightController depends on the PrefService to read and write
user prefs related to NightLight. It uses a PrefChangeRegistrar to
observe changes to those prefs. PrefChangeRegistrar is not expected
to outlive the PrefService, and hence must be destroyed first.

BUG=724231
TEST=Start chrome with --mash and expects to see no crashes
NightLightController when Shell is destroyed.

Review-Url: https://codereview.chromium.org/2892983002
Cr-Commit-Position: refs/heads/master@{#473375}
Committed:
https://chromium.googlesource.com/chromium/src/+/21501560f5074b5e07c397fedc09...
==========

[commit-bot: I haz the power, 2017-05-19 22:53:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/21501560f5074b5e07c397fedc09...