Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 2892983002: Destroy NightLightController before PrefService (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 days ago by afakhry
Modified:
4 days, 19 hours ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Destroy NightLightController before PrefService NightLightController depends on the PrefService to read and write user prefs related to NightLight. It uses a PrefChangeRegistrar to observe changes to those prefs. PrefChangeRegistrar is not expected to outlive the PrefService, and hence must be destroyed first. BUG=724231 TEST=Start chrome with --mash and expects to see no crashes NightLightController when Shell is destroyed. Review-Url: https://codereview.chromium.org/2892983002 Cr-Commit-Position: refs/heads/master@{#473375} Committed: https://chromium.googlesource.com/chromium/src/+/21501560f5074b5e07c397fedc09d47a0a6c5b3f

Patch Set 1 #

Messages

Total messages: 8 (4 generated)
afakhry
Sky, please take a look. Thank you.
5 days ago (2017-05-19 17:24:36 UTC) #2
sky
LGTM
4 days, 21 hours ago (2017-05-19 20:01:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892983002/1
4 days, 20 hours ago (2017-05-19 21:45:44 UTC) #5
commit-bot: I haz the power
4 days, 19 hours ago (2017-05-19 22:53:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/21501560f5074b5e07c397fedc09...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06