Remove the ClearCookies and ClearCache methods from ContentBrowserClient

android_webview/browser/aw_contents.cc

Index: android_webview/browser/aw_contents.cc
diff --git a/android_webview/browser/aw_contents.cc b/android_webview/browser/aw_contents.cc
index 45fc4ff0747ec3bd09332abdd8eb28a86b0176aa..4785d3121fcc45caba0b90a39ceebdd7ceff9c78 100644
--- a/android_webview/browser/aw_contents.cc
+++ b/android_webview/browser/aw_contents.cc
@@ -712,6 +712,9 @@ void AwContents::ClearCache(JNIEnv* env,
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   render_view_host_ext_->ClearCache();
 
+  // TODO(crbug.com/668114): This functionality is a subset of what
+  // BrowsingDataRemover would do for REMOVE_CACHE mask. Consider calling that

[boliu, 2017/05/19 17:31:31]

so what does does REMOVE_CACHE remove?

[msramek, 2017/05/19 17:35:29]

It calls to StoragePartitionHttpCacheDataRemover, which clears
disk_cache::Backend for HTTP and media request contexts (same as android_webview
already does), and then also QUIC and SDCH configuration.

[boliu, 2017/05/19 17:38:36]

Ahh, different protocols. Yes, this should clear those as well.

[msramek, 2017/05/19 18:14:59]

Actually, I have one clarifying question :) BrowsingDataRemover clears cache for
the default storage partition, because in Chrome, only packaged apps have
separate storage partitions and we don't need to handle their data deletion.

Does android_webview use more than one storage partition? If it's possible that
web_contents_->GetRenderProcessHost() on line 719 uses a nondefault storage
partition, then we can't straightforwardly replace this with
BrowsingDataRemover. (But we would still be able to use
StoragePartitionHttpCacheDataRemover to delete QUIC and SDCH).

+  // instead.
   if (include_disk_files)
     RemoveHttpDiskCache(web_contents_->GetRenderProcessHost());
 }