Remove the ClearCookies and ClearCache methods from ContentBrowserClient

android_webview/browser/aw_contents.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_contents.h"
 
 #include <limits>
 #include <utility>
 
 #include "android_webview/browser/aw_autofill_client.h"
@@ skipping 694 matching lines @@
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   GetFindHelper()->ClearMatches();
 }
 
 void AwContents::ClearCache(JNIEnv* env,
                             const JavaParamRef<jobject>& obj,
                             jboolean include_disk_files) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   render_view_host_ext_->ClearCache();
 
+  // TODO(crbug.com/668114): This functionality is a subset of what
+  // BrowsingDataRemover would do for REMOVE_CACHE mask. Consider calling that

[boliu, 2017/05/19 17:31:31]

so what does does REMOVE_CACHE remove?

[msramek, 2017/05/19 17:35:29]

It calls to StoragePartitionHttpCacheDataRemover, which clears
disk_cache::Backend for HTTP and media request contexts (same as android_webview
already does), and then also QUIC and SDCH configuration.

[boliu, 2017/05/19 17:38:36]

Ahh, different protocols. Yes, this should clear those as well.

[msramek, 2017/05/19 18:14:59]

Actually, I have one clarifying question :) BrowsingDataRemover clears cache for
the default storage partition, because in Chrome, only packaged apps have
separate storage partitions and we don't need to handle their data deletion.

Does android_webview use more than one storage partition? If it's possible that
web_contents_->GetRenderProcessHost() on line 719 uses a nondefault storage
partition, then we can't straightforwardly replace this with
BrowsingDataRemover. (But we would still be able to use
StoragePartitionHttpCacheDataRemover to delete QUIC and SDCH).

+  // instead.
   if (include_disk_files)
     RemoveHttpDiskCache(web_contents_->GetRenderProcessHost());
 }
 
 void AwContents::KillRenderProcess(JNIEnv* env,
                                    const JavaParamRef<jobject>& obj) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   render_view_host_ext_->KillRenderProcess();
 }
 
@@ skipping 720 matching lines @@
 
   return Java_AwContents_onRenderProcessGoneDetail(env, obj, child_process_id,
                                                    crashed);
 }
 
 void AwContents::RenderProcessReady(content::RenderProcessHost* host) {
   UpdateRendererPriority();
 }
 
 }  // namespace android_webview