Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(416)

Issue 2892923002: Remove SupportsWeakPtr from GPUTracer and CommandExecutor (Closed)

Created:
1 year ago by Chandan
Modified:
1 year ago
Reviewers:
Zhenyao Mo, piman
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SupportsWeakPtr from GPUTracer and CommandExecutor GPUTracer and CommandExecutor unnecessarily inherit SupportsWeakPtr. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2892923002 Cr-Commit-Position: refs/heads/master@{#473804} Committed: https://chromium.googlesource.com/chromium/src/+/6df0b5c128f7ebfe6c6cc3b8bd496ea3e13fa8cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M gpu/command_buffer/service/command_executor.h View 2 chunks +1 line, -3 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer.h View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Chandan
Minor cleanup. PTAL. Thank you.
1 year ago (2017-05-19 14:23:56 UTC) #5
Chandan
+piman@ PTAL.
1 year ago (2017-05-22 19:26:23 UTC) #9
piman
lgtm
1 year ago (2017-05-22 19:34:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892923002/1
1 year ago (2017-05-23 03:01:26 UTC) #12
commit-bot: I haz the power
1 year ago (2017-05-23 03:54:54 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6df0b5c128f7ebfe6c6cc3b8bd49...

Powered by Google App Engine
This is Rietveld 408576698