Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2892903002: Renamed `embedding-csp` HTTP request header to `required-csp`. (Closed)

Created:
3 years, 7 months ago by andypaicu
Modified:
3 years, 7 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, kinuko+watch, Yoav Weiss
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed all instances of embedding-csp to required-csp Also removed 2 support files that were unused Spec: https://w3c.github.io/webappsec-csp/embedded/#required-csp-header BUG=647588 Review-Url: https://codereview.chromium.org/2892903002 Cr-Commit-Position: refs/heads/master@{#473547} Committed: https://chromium.googlesource.com/chromium/src/+/3f8d3c41da42aa0206f70f86dd00ea1e4d575f26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -239 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/embedded-enforcement/embedding_csp-header.html View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/embedded-enforcement/embedding_csp-header-invalid-format.html View 1 chunk +0 lines, -70 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/content-security-policy/embedded-enforcement/required_csp-header.html View 2 chunks +19 lines, -19 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/content-security-policy/embedded-enforcement/required_csp-header-invalid-format.html View 1 chunk +18 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/embedded-enforcement/support/echo-embedding-csp.py View 1 chunk +0 lines, -15 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/content-security-policy/embedded-enforcement/support/echo-required-csp.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/content-security-policy/embedded-enforcement/support/testharness-helper.sub.js View 2 chunks +4 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/resources/get-embedding-csp-header.php View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/resources/get-embedding-csp-header-and-respond.php View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/network/HTTPNames.json5 View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
andypaicu
3 years, 7 months ago (2017-05-19 09:41:32 UTC) #4
Mike West
LGTM, thanks!
3 years, 7 months ago (2017-05-21 05:11:26 UTC) #7
Mike West
Nits: 1. Please link to the relevant bit of the spec in the CL description. ...
3 years, 7 months ago (2017-05-22 07:47:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892903002/1
3 years, 7 months ago (2017-05-22 08:36:16 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 10:58:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3f8d3c41da42aa0206f70f86dd00...

Powered by Google App Engine
This is Rietveld 408576698