Initial implementation of new-style notification

chrome/browser/about_flags.cc

Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 4c903959166b8ce50ce21417701a0f86776bec50..8f2a09d672a372bdf1a66710c2fd4349e48efe3c 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -443,6 +443,17 @@ const FeatureEntry::Choice kAshShelfColorSchemeChoices[] = {
 };
 #endif  // USE_ASH
 
+#if !defined(OS_ANDROID)
+const FeatureEntry::Choice kMessageCenterNewStyleNotificationChoices[] = {
+    {flags_ui::kGenericExperimentChoiceDefault, "", ""},
+    {flags_ui::kGenericExperimentChoiceEnabled,
+     switches::kMessageCenterNewStyleNotification,
+     switches::kMessageCenterNewStyleNotificationEnabled},
+    {flags_ui::kGenericExperimentChoiceDisabled,
+     switches::kMessageCenterNewStyleNotification,
+     switches::kMessageCenterNewStyleNotificationDisabled}};
+#endif  // !OS_ANDROID
+
 #if defined(OS_CHROMEOS)
 const FeatureEntry::Choice kAshMaterialDesignInkDropAnimationSpeed[] = {
     {flags_ui::kGenericExperimentChoiceDefault, "", ""},
@@ -1846,6 +1857,10 @@ const FeatureEntry kFeatureEntries[] = {
      kOsDesktop,
      SINGLE_VALUE_TYPE(
          switches::kEnableMessageCenterAlwaysScrollUpUponNotificationRemoval)},
+    {"enable-message-center-new-style-notification",
+     flag_descriptions::kMessageCenterNewStyleNotificationName,
+     flag_descriptions::kMessageCenterNewStyleNotificationDescription,
+     kOsDesktop, MULTI_VALUE_TYPE(kMessageCenterNewStyleNotificationChoices)},

[fukino, 2017/05/25 07:35:10]

Can we use ENABLE_DISABLE_VALUE_TYPE to make related code simpler?

[yoshiki, 2017/05/29 03:52:38]

I want to make it tri-state since we may re-disable the feature after enabling
it. If it is binary, the user who has set to enabled or disabled once can't
change back to the default.

[fukino, 2017/05/30 07:32:32]

We have Enable/Disable/Default in chrome://flags for ENABLE_DISABLE_VALUE_TYPE
We can change the default behavior when we don't have either kEnableXxx or
kDisableXxx.
Doesn't it work for our user case?
If it doesn't work, having MULTI_VALUE_TYPE lgtm.

[yoshiki, 2017/05/31 03:53:01]

Ah, I confused with SINGLE_VALUE_TYPE. Ok, let me change.

 #endif  // !OS_ANDROID
     {"enable-md-policy-page",
      flag_descriptions::kEnableMaterialDesignPolicyPageName,