Initial implementation of new-style notification

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 425 matching lines @@
      ash::switches::kAshShelfColorSchemeLightMuted},
     {flag_descriptions::kAshShelfColorSchemeNormalMuted,
      ash::switches::kAshShelfColorScheme,
      ash::switches::kAshShelfColorSchemeNormalMuted},
     {flag_descriptions::kAshShelfColorSchemeDarkMuted,
      ash::switches::kAshShelfColorScheme,
      ash::switches::kAshShelfColorSchemeDarkMuted},
 };
 #endif  // USE_ASH
 
+#if !defined(OS_ANDROID)
+const FeatureEntry::Choice kMessageCenterNewStyleNotificationChoices[] = {
+    {flags_ui::kGenericExperimentChoiceDefault, "", ""},
+    {flags_ui::kGenericExperimentChoiceEnabled,
+     switches::kMessageCenterNewStyleNotification,
+     switches::kMessageCenterNewStyleNotificationEnabled},
+    {flags_ui::kGenericExperimentChoiceDisabled,
+     switches::kMessageCenterNewStyleNotification,
+     switches::kMessageCenterNewStyleNotificationDisabled}};
+#endif  // !OS_ANDROID
+
 #if defined(OS_CHROMEOS)
 const FeatureEntry::Choice kAshMaterialDesignInkDropAnimationSpeed[] = {
     {flags_ui::kGenericExperimentChoiceDefault, "", ""},
     {flag_descriptions::kMaterialDesignInkDropAnimationFast,
      switches::kMaterialDesignInkDropAnimationSpeed,
      switches::kMaterialDesignInkDropAnimationSpeedFast},
     {flag_descriptions::kMaterialDesignInkDropAnimationSlow,
      switches::kMaterialDesignInkDropAnimationSpeed,
      switches::kMaterialDesignInkDropAnimationSpeedSlow}};
 
@@ skipping 1383 matching lines @@
     {"drop-sync-credential", flag_descriptions::kDropSyncCredentialName,
      flag_descriptions::kDropSyncCredentialDescription, kOsAll,
      FEATURE_VALUE_TYPE(password_manager::features::kDropSyncCredential)},
 #if !defined(OS_ANDROID)
     {"enable-message-center-always-scroll-up-upon-notification-removal",
      flag_descriptions::kMessageCenterAlwaysScrollUpUponRemovalName,
      flag_descriptions::kMessageCenterAlwaysScrollUpUponRemovalDescription,
      kOsDesktop,
      SINGLE_VALUE_TYPE(
          switches::kEnableMessageCenterAlwaysScrollUpUponNotificationRemoval)},
+    {"enable-message-center-new-style-notification",
+     flag_descriptions::kMessageCenterNewStyleNotificationName,
+     flag_descriptions::kMessageCenterNewStyleNotificationDescription,
+     kOsDesktop, MULTI_VALUE_TYPE(kMessageCenterNewStyleNotificationChoices)},

[fukino, 2017/05/25 07:35:10]

Can we use ENABLE_DISABLE_VALUE_TYPE to make related code simpler?

[yoshiki, 2017/05/29 03:52:38]

I want to make it tri-state since we may re-disable the feature after enabling
it. If it is binary, the user who has set to enabled or disabled once can't
change back to the default.

[fukino, 2017/05/30 07:32:32]

We have Enable/Disable/Default in chrome://flags for ENABLE_DISABLE_VALUE_TYPE
We can change the default behavior when we don't have either kEnableXxx or
kDisableXxx.
Doesn't it work for our user case?
If it doesn't work, having MULTI_VALUE_TYPE lgtm.

[yoshiki, 2017/05/31 03:53:01]

Ah, I confused with SINGLE_VALUE_TYPE. Ok, let me change.

 #endif  // !OS_ANDROID
     {"enable-md-policy-page",
      flag_descriptions::kEnableMaterialDesignPolicyPageName,
      flag_descriptions::kEnableMaterialDesignPolicyPageDescription, kOsDesktop,
      SINGLE_VALUE_TYPE(switches::kEnableMaterialDesignPolicyPage)},
 #if defined(OS_CHROMEOS)
     {"memory-pressure-thresholds",
      flag_descriptions::kMemoryPressureThresholdName,
      flag_descriptions::kMemoryPressureThresholdDescription, kOsCrOS,
      MULTI_VALUE_TYPE(kMemoryPressureThresholdChoices)},
@@ skipping 1377 matching lines @@
 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags