Bit-pack bools in scroll and effect nodes.

Bit-pack bools in scroll and effect nodes.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2892853002
Cr-Commit-Position: refs/heads/master@{#473062}
Committed: https://chromium.googlesource.com/chromium/src/+/290bf5b64df386923fb35f9b964c768153b3dd37

[wkorman, 2017-05-18 23:30:30]

Description was changed from

==========
Bit-pack bools in scroll and effect nodes.

BUG=709137
==========

to

==========
Bit-pack bools in scroll and effect nodes.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[wkorman, 2017-05-18 23:37:04]

wkorman@chromium.org changed reviewers:
+ enne@chromium.org, pdr@chromium.org

[wkorman, 2017-05-18 23:37:04]

For discussion. cc::TransformNode already bit-packs.

How to consider performance vs memory tradeoff? Or
should we just land it and see what happens.

We could try CT run, or extrapolate from manual
exploration of node count on some top trafficked
sites.

How does Blink decide when/whether to do this?

bool field count:

Transform : 19
Effect    : 12
Scroll    : 7
Clip      : 0

I went back as far as trchen@ patch where we
de-templatized the nodes, and at that time we
bit-packed transform and clip. Clip no longer
has any bools. See:

https://codereview.chromium.org/2118993002/patch/120001/130028

[pdr., 2017-05-18 23:49:43]

On 2017/05/18 at 23:37:04, wkorman wrote:
> For discussion. cc::TransformNode already bit-packs.
> 
> How to consider performance vs memory tradeoff? Or
> should we just land it and see what happens.
> 
> We could try CT run, or extrapolate from manual
> exploration of node count on some top trafficked
> sites.
> 
> How does Blink decide when/whether to do this?
> 
> bool field count:
> 
> Transform : 19
> Effect    : 12
> Scroll    : 7
> Clip      : 0
> 
> I went back as far as trchen@ patch where we
> de-templatized the nodes, and at that time we
> bit-packed transform and clip. Clip no longer
> has any bools. See:
> 
> https://codereview.chromium.org/2118993002/patch/120001/130028

IMO, a good idea. LGTM

[enne (OOO), 2017-05-19 00:48:10]

Sure, lgtm.  I don't feel super strongly about this.

[wkorman, 2017-05-19 01:20:46]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2017-05-19 01:20:46]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2892853002/#ps20001
(title: "Fix init order.")

[commit-bot: I haz the power, 2017-05-19 01:22:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 02:50:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 02:50:49]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wkorman, 2017-05-19 03:00:27]

The CQ bit was checked by wkorman@chromium.org

[commit-bot: I haz the power, 2017-05-19 03:01:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 03:41:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495162827692900,
"parent_rev": "f079dc7ab352ebef915f311e4a06054f07943396", "commit_rev":
"290bf5b64df386923fb35f9b964c768153b3dd37"}

[commit-bot: I haz the power, 2017-05-19 03:41:45]

Description was changed from

==========
Bit-pack bools in scroll and effect nodes.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Bit-pack bools in scroll and effect nodes.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2892853002
Cr-Commit-Position: refs/heads/master@{#473062}
Committed:
https://chromium.googlesource.com/chromium/src/+/290bf5b64df386923fb35f9b964c...
==========

[commit-bot: I haz the power, 2017-05-19 03:41:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/290bf5b64df386923fb35f9b964c...