Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: extensions/browser/api/runtime/runtime_api.cc

Issue 2892843002: Remove RuntimeAPIDelegate::GetPreviousVersion. (Closed)
Patch Set: address missing comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/runtime/runtime_api.cc
diff --git a/extensions/browser/api/runtime/runtime_api.cc b/extensions/browser/api/runtime/runtime_api.cc
index dbd9e915ece64464b8b380f6940b18b3c48fb252..11b8f758f56a819e41c73c945e49fde2d5607cf1 100644
--- a/extensions/browser/api/runtime/runtime_api.cc
+++ b/extensions/browser/api/runtime/runtime_api.cc
@@ -320,8 +320,8 @@ void RuntimeAPI::StorePendingOnInstallInfoToPref(const Extension* extension) {
// so that we can add more stuff to it in the future if necessary.
std::unique_ptr<base::DictionaryValue> pending_on_install_info(
new base::DictionaryValue());
- base::Version previous_version =
- delegate_->GetPreviousExtensionVersion(extension);
+ base::Version previous_version = ExtensionRegistry::Get(browser_context_)
+ ->GetStoredVersion(extension->id());
pending_on_install_info->SetString(
kPrefPreviousVersion,
previous_version.IsValid() ? previous_version.GetString() : "");

Powered by Google App Engine
This is Rietveld 408576698