Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5567)

Unified Diff: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

Issue 2892843002: Remove RuntimeAPIDelegate::GetPreviousVersion. (Closed)
Patch Set: address missing comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc
diff --git a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc
index 0aa9c6a2a71d7d2cfd652acb1b370fa2ffddbc38..d4c0b762a4619ee522d867aa3f8196b906b0e510 100644
--- a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc
+++ b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc
@@ -170,17 +170,6 @@ void ChromeRuntimeAPIDelegate::RemoveUpdateObserver(
}
}
-base::Version ChromeRuntimeAPIDelegate::GetPreviousExtensionVersion(
- const Extension* extension) {
- // Get the previous version to check if this is an upgrade.
- ExtensionService* service =
- ExtensionSystem::Get(browser_context_)->extension_service();
- const Extension* old = service->GetExtensionById(extension->id(), true);
- if (old)
- return *old->version();
- return base::Version();
-}
-
void ChromeRuntimeAPIDelegate::ReloadExtension(
const std::string& extension_id) {
std::pair<base::TimeTicks, int>& reload_info =
« no previous file with comments | « chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.h ('k') | extensions/browser/api/runtime/runtime_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698