Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2892833002: [Payments] Use event to log checkout funnel metrics. (Closed)

Created:
3 years, 7 months ago by sebsg
Modified:
3 years, 7 months ago
Reviewers:
Mathieu, gogerald1
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, agrieve+watch_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Use event to log checkout funnel metrics. BUG=724256 Review-Url: https://codereview.chromium.org/2892833002 Cr-Commit-Position: refs/heads/master@{#473372} Committed: https://chromium.googlesource.com/chromium/src/+/6ae7018ea85eabd5c341126227cb3403a2c1e5b6

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -26 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 5 chunks +1 line, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java View 5 chunks +23 lines, -20 lines 0 comments Download
M components/payments/core/journey_logger.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M components/payments/core/journey_logger.cc View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
sebsg
Hi gogerald@ and mathp@, could you please take a look? I'm writing the code to ...
3 years, 7 months ago (2017-05-19 13:29:11 UTC) #7
gogerald1
lgtm with a nit https://codereview.chromium.org/2892833002/diff/20001/components/payments/core/journey_logger.h File components/payments/core/journey_logger.h (right): https://codereview.chromium.org/2892833002/diff/20001/components/payments/core/journey_logger.h#newcode139 components/payments/core/journey_logger.h:139: // Records the histograms for ...
3 years, 7 months ago (2017-05-19 19:42:17 UTC) #8
Mathieu
lgtm
3 years, 7 months ago (2017-05-19 21:10:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892833002/40001
3 years, 7 months ago (2017-05-19 21:13:10 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 22:48:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6ae7018ea85eabd5c341126227cb...

Powered by Google App Engine
This is Rietveld 408576698