Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 289283020: Oilpan: avoid leak on creating shadow document wrapper. (Closed)

Created:
6 years, 7 months ago by sof
Modified:
6 years, 7 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: avoid leak on creating shadow document wrapper. BUG=357163 TBR=haraken@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174582

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/bindings/v8/V8DOMWrapper.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
sof
Please take a look. Perhaps this is on the way via https://codereview.chromium.org/296943005/ already? Just in ...
6 years, 7 months ago (2014-05-22 15:06:12 UTC) #1
sof
On 2014/05/22 15:06:12, sof wrote: > Please take a look. > > Perhaps this is ...
6 years, 7 months ago (2014-05-22 16:06:22 UTC) #2
zerny-chromium
On 2014/05/22 16:06:22, sof wrote: > On 2014/05/22 15:06:12, sof wrote: > > Please take ...
6 years, 7 months ago (2014-05-22 17:56:51 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 7 months ago (2014-05-22 18:08:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/289283020/1
6 years, 7 months ago (2014-05-22 18:09:37 UTC) #5
commit-bot: I haz the power
Change committed as 174582
6 years, 7 months ago (2014-05-22 18:10:25 UTC) #6
sof
Thanks Ian for the confirmation.
6 years, 7 months ago (2014-05-22 18:21:21 UTC) #7
haraken
6 years, 7 months ago (2014-05-22 20:06:14 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698