Source/bindings/v8/V8DOMWrapper.cpp - Issue 289283020: Oilpan: avoid leak on creating shadow document wrapper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8DOMWrapper.cpp

Issue 289283020: Oilpan: avoid leak on creating shadow document wrapper. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/V8DOMWrapper.cpp

diff --git a/Source/bindings/v8/V8DOMWrapper.cpp b/Source/bindings/v8/V8DOMWrapper.cpp

index 7efe6372bd188ba9e019f4e8b3055345d13e75eb..d825e3e4e22a534b97f281a80e85e69384d2fe69 100644

--- a/Source/bindings/v8/V8DOMWrapper.cpp

+++ b/Source/bindings/v8/V8DOMWrapper.cpp

@@ -64,7 +64,7 @@ static v8::Local<v8::Object> wrapInShadowTemplate(v8::Local<v8::Object> wrapper,

if (shadow.IsEmpty())

return v8::Local<v8::Object>();

shadow->SetPrototype(wrapper);

- V8DOMWrapper::setNativeInfo(wrapper, &V8HTMLDocument::wrapperTypeInfo, impl);

+ V8DOMWrapper::setNativeInfoForHiddenWrapper(wrapper, &V8HTMLDocument::wrapperTypeInfo, impl);

return shadow;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »