Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 289283019: Remove canvas.drawCustomFocusRing() (Closed)

Created:
6 years, 7 months ago by zino
Modified:
6 years, 6 months ago
CC:
blink-reviews, arv+blink, blink-reviews-html_chromium.org, dglazkov+blink, Inactive, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove canvas.drawCustomFocusRing() The method was removed from the HTML Canvas2D Context Level 1 Specification: http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas_CR#removals Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175036

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -46 lines) Patch
D LayoutTests/fast/canvas/draw-custom-focus-ring.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/canvas/draw-custom-focus-ring-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/inspector/profiler/canvas2d/canvas2d-api-changes-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Justin Novosad
Is drawCustomFocusRing slated to be removed from the spec?
6 years, 7 months ago (2014-05-27 21:29:28 UTC) #1
Rik
On 2014/05/27 21:29:28, junov wrote: > Is drawCustomFocusRing slated to be removed from the spec? ...
6 years, 7 months ago (2014-05-27 23:13:47 UTC) #2
dmazzoni
On Tue, May 27, 2014 at 4:13 PM, <cabanier@adobe.com> wrote: > On 2014/05/27 21:29:28, junov ...
6 years, 6 months ago (2014-05-28 15:27:18 UTC) #3
eseidel
rslgtm.
6 years, 6 months ago (2014-05-28 22:10:55 UTC) #4
zino
On 2014/05/28 22:10:55, eseidel wrote: > rslgtm. Dear all, So, do we all agree to ...
6 years, 6 months ago (2014-05-29 03:56:41 UTC) #5
dmazzoni
lgtm I think we're all in agreement, let's get rid of it. Thanks!
6 years, 6 months ago (2014-05-29 04:12:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/289283019/20001
6 years, 6 months ago (2014-05-29 04:12:33 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 05:31:35 UTC) #8
Message was sent while issue was closed.
Change committed as 175036

Powered by Google App Engine
This is Rietveld 408576698