Issue 289283018: Cleanup after inobject slack tracking improvement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 289283018: Cleanup after inobject slack tracking improvement. (Closed)

Created:
6 years, 7 months ago by Igor Sheludko

Modified:
6 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Cleanup after inobject slack tracking improvement. 1) %SetExpectedNumberOfProperties() function removed. 2) Obsolete SharedFunctionInfo::BeforeVisitingPointers() removed. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21464

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing review comments + rebase #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -44 lines)			Patch
M	src/bootstrapper.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/incremental-marking.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/mark-compact.cc	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/objects.h	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/objects-inl.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/objects-visiting-inl.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/runtime.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/v8natives.js	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
D	test/mjsunit/runtime-gen/setexpectednumberofproperties.js	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	tools/generate-runtime-tests.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/289283018/diff/20001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/289283018/diff/20001/src/objects.h#newcode2632 src/objects.h:2632: static const int kInitialUnusedPropertiesCount = 4; nit: Can ...

6 years, 7 months ago (2014-05-22 10:37:49 UTC) #2

Igor Sheludko

6 years, 7 months ago (2014-05-23 12:56:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21464 (presubmit successful).

Expand Messages | Collapse Messages