Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: src/objects-visiting-inl.h

Issue 289283018: Cleanup after inobject slack tracking improvement. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing review comments + rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-inl.h ('k') | src/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_VISITING_INL_H_ 5 #ifndef V8_OBJECTS_VISITING_INL_H_
6 #define V8_OBJECTS_VISITING_INL_H_ 6 #define V8_OBJECTS_VISITING_INL_H_
7 7
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
(...skipping 776 matching lines...) Expand 10 before | Expand all | Expand 10 after
787 return false; 787 return false;
788 } 788 }
789 789
790 return true; 790 return true;
791 } 791 }
792 792
793 793
794 template<typename StaticVisitor> 794 template<typename StaticVisitor>
795 void StaticMarkingVisitor<StaticVisitor>::VisitSharedFunctionInfoStrongCode( 795 void StaticMarkingVisitor<StaticVisitor>::VisitSharedFunctionInfoStrongCode(
796 Heap* heap, HeapObject* object) { 796 Heap* heap, HeapObject* object) {
797 StaticVisitor::BeforeVisitingSharedFunctionInfo(object);
798 Object** start_slot = 797 Object** start_slot =
799 HeapObject::RawField(object, 798 HeapObject::RawField(object,
800 SharedFunctionInfo::BodyDescriptor::kStartOffset); 799 SharedFunctionInfo::BodyDescriptor::kStartOffset);
801 Object** end_slot = 800 Object** end_slot =
802 HeapObject::RawField(object, 801 HeapObject::RawField(object,
803 SharedFunctionInfo::BodyDescriptor::kEndOffset); 802 SharedFunctionInfo::BodyDescriptor::kEndOffset);
804 StaticVisitor::VisitPointers(heap, start_slot, end_slot); 803 StaticVisitor::VisitPointers(heap, start_slot, end_slot);
805 } 804 }
806 805
807 806
808 template<typename StaticVisitor> 807 template<typename StaticVisitor>
809 void StaticMarkingVisitor<StaticVisitor>::VisitSharedFunctionInfoWeakCode( 808 void StaticMarkingVisitor<StaticVisitor>::VisitSharedFunctionInfoWeakCode(
810 Heap* heap, HeapObject* object) { 809 Heap* heap, HeapObject* object) {
811 StaticVisitor::BeforeVisitingSharedFunctionInfo(object);
812 Object** name_slot = 810 Object** name_slot =
813 HeapObject::RawField(object, SharedFunctionInfo::kNameOffset); 811 HeapObject::RawField(object, SharedFunctionInfo::kNameOffset);
814 StaticVisitor::VisitPointer(heap, name_slot); 812 StaticVisitor::VisitPointer(heap, name_slot);
815 813
816 // Skip visiting kCodeOffset as it is treated weakly here. 814 // Skip visiting kCodeOffset as it is treated weakly here.
817 STATIC_ASSERT(SharedFunctionInfo::kNameOffset + kPointerSize == 815 STATIC_ASSERT(SharedFunctionInfo::kNameOffset + kPointerSize ==
818 SharedFunctionInfo::kCodeOffset); 816 SharedFunctionInfo::kCodeOffset);
819 STATIC_ASSERT(SharedFunctionInfo::kCodeOffset + kPointerSize == 817 STATIC_ASSERT(SharedFunctionInfo::kCodeOffset + kPointerSize ==
820 SharedFunctionInfo::kOptimizedCodeMapOffset); 818 SharedFunctionInfo::kOptimizedCodeMapOffset);
821 819
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
932 RelocIterator it(this, mode_mask); 930 RelocIterator it(this, mode_mask);
933 for (; !it.done(); it.next()) { 931 for (; !it.done(); it.next()) {
934 it.rinfo()->template Visit<StaticVisitor>(heap); 932 it.rinfo()->template Visit<StaticVisitor>(heap);
935 } 933 }
936 } 934 }
937 935
938 936
939 } } // namespace v8::internal 937 } } // namespace v8::internal
940 938
941 #endif // V8_OBJECTS_VISITING_INL_H_ 939 #endif // V8_OBJECTS_VISITING_INL_H_
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | src/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698