Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 289283012: [Metrics] Move CommandLine metrics out of MetricsService (Closed)

Created:
6 years, 7 months ago by Ilya Sherman
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, blundell
Visibility:
Public.

Description

[Metrics] Move CommandLine metrics out of MetricsService BUG=375774 TEST=none R=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272280

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -20 lines) Patch
M chrome/browser/metrics/chrome_metrics_service_client.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 2 4 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 3 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ilya Sherman
6 years, 7 months ago (2014-05-21 15:56:01 UTC) #1
Alexei Svitkine (slow)
LGTM
6 years, 7 months ago (2014-05-21 16:00:11 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-21 16:01:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/289283012/1
6 years, 7 months ago (2014-05-21 19:59:07 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 08:25:00 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 10:17:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/18042)
6 years, 7 months ago (2014-05-22 10:17:57 UTC) #7
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-22 11:35:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/289283012/20001
6 years, 7 months ago (2014-05-22 11:37:57 UTC) #9
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-22 15:58:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/289283012/40001
6 years, 7 months ago (2014-05-22 16:00:14 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 19:41:24 UTC) #12
Message was sent while issue was closed. 
Change committed as 272280

Powered by Google App Engine
This is Rietveld 408576698