Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3755)

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 289283012: [Metrics] Move CommandLine metrics out of MetricsService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service.cc
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc
index b6fca9f1eb9fea25efa4eab499137c5e9d5f297a..0e1af5c07c0559fde8e5dcfd4f435bb1841227fc 100644
--- a/chrome/browser/metrics/metrics_service.cc
+++ b/chrome/browser/metrics/metrics_service.cc
@@ -167,7 +167,6 @@
#include "base/bind.h"
#include "base/callback.h"
-#include "base/command_line.h"
#include "base/metrics/histogram.h"
#include "base/metrics/sparse_histogram.h"
#include "base/metrics/statistics_recorder.h"
@@ -191,7 +190,6 @@
#include "chrome/browser/metrics/tracking_synchronizer.h"
#include "chrome/browser/ui/browser_otr_state.h"
#include "chrome/common/chrome_constants.h"
-#include "chrome/common/chrome_switches.h"
#include "chrome/common/crash_keys.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/variations/variations_util.h"
@@ -846,24 +844,6 @@ void MetricsService::InitializeMetricsState() {
// Bookkeeping for the uninstall metrics.
IncrementLongPrefsValue(prefs::kUninstallLaunchCount);
- // Get stats on use of command line.
- const CommandLine* command_line(CommandLine::ForCurrentProcess());
- size_t common_commands = 0;
- if (command_line->HasSwitch(switches::kUserDataDir)) {
- ++common_commands;
- UMA_HISTOGRAM_COUNTS_100("Chrome.CommandLineDatDirCount", 1);
- }
-
- if (command_line->HasSwitch(switches::kApp)) {
- ++common_commands;
- UMA_HISTOGRAM_COUNTS_100("Chrome.CommandLineAppModeCount", 1);
- }
-
- size_t switch_count = command_line->GetSwitches().size();
- UMA_HISTOGRAM_COUNTS_100("Chrome.CommandLineFlagCount", switch_count);
- UMA_HISTOGRAM_COUNTS_100("Chrome.CommandLineUncommonFlagCount",
- switch_count - common_commands);
-
// Kick off the process of saving the state (so the uptime numbers keep
// getting updated) every n minutes.
ScheduleNextStateSave();
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698