Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issue 289283010: Comment fix for submitted patch: 267423005 (Closed)

Created:
6 years, 7 months ago by h.joshi
Modified:
6 years, 7 months ago
Reviewers:
a.suchit2, Dirk Pranke
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Comment fix for submitted patch: https://codereview.chromium.org/267423005 This patch renames README file to README.chromium and also updated command to generate subset font BUG=372502 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174790

Patch Set 1 : Updating file name as per comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21 lines) Patch
A + LayoutTests/third_party/NotoSans/README.chromium View 2 chunks +2 lines, -2 lines 0 comments Download
D LayoutTests/third_party/NotoSans/README.txt View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
h.joshi
PTAL
6 years, 7 months ago (2014-05-22 01:17:44 UTC) #1
Dirk Pranke
lgtm
6 years, 7 months ago (2014-05-22 01:20:17 UTC) #2
h.joshi
The CQ bit was checked by h.joshi@samsung.com
6 years, 7 months ago (2014-05-22 01:21:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/h.joshi@samsung.com/289283010/30004
6 years, 7 months ago (2014-05-22 01:22:47 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 11:43:08 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 11:44:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9731)
6 years, 7 months ago (2014-05-22 11:44:13 UTC) #7
h.joshi
The CQ bit was checked by h.joshi@samsung.com
6 years, 7 months ago (2014-05-22 13:57:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/h.joshi@samsung.com/289283010/30004
6 years, 7 months ago (2014-05-22 13:58:03 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 13:59:24 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 14:00:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9731)
6 years, 7 months ago (2014-05-22 14:00:36 UTC) #12
h.joshi
win_gpu_triggered_test is showing "fatal: remote error: User Is Over Quota" in logs, not sure what ...
6 years, 7 months ago (2014-05-24 02:29:21 UTC) #13
a.suchit2
The CQ bit was checked by a.suchit@chromium.org
6 years, 7 months ago (2014-05-26 07:06:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/h.joshi@samsung.com/289283010/30004
6 years, 7 months ago (2014-05-26 07:06:59 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 08:55:26 UTC) #16
Message was sent while issue was closed.
Change committed as 174790

Powered by Google App Engine
This is Rietveld 408576698