Adding NotoSans subset font file which is required to test new language

Adding NotoSans subset font file which is required to test new language
attribute feature.

BUG=372502
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174351

[h.joshi, 2014-05-14 12:37:42]

Font file to test Hindi and Nepali language rendering.

[eseidel, 2014-05-14 12:50:12]

https://codereview.chromium.org/267423005/diff/1/LayoutTests/third_party/Noto...
File LayoutTests/third_party/NotoSans/LICENSE.txt (right):

https://codereview.chromium.org/267423005/diff/1/LayoutTests/third_party/Noto...
LayoutTests/third_party/NotoSans/LICENSE.txt:1: Copyright [yyyy] [name of
copyright owner]
This looks wrong.

https://codereview.chromium.org/267423005/diff/1/LayoutTests/third_party/Noto...
File LayoutTests/third_party/NotoSans/README.txt (right):

https://codereview.chromium.org/267423005/diff/1/LayoutTests/third_party/Noto...
LayoutTests/third_party/NotoSans/README.txt:9: We publish our fonts under the
terms of the GPL (see GPL.txt) and OFL (OFL.txt)
This does not agree with the license file you added.

[h.joshi, 2014-05-14 13:04:14]

New patch added, PTAL

https://codereview.chromium.org/267423005/diff/1/LayoutTests/third_party/Noto...
File LayoutTests/third_party/NotoSans/LICENSE.txt (right):

https://codereview.chromium.org/267423005/diff/1/LayoutTests/third_party/Noto...
LayoutTests/third_party/NotoSans/LICENSE.txt:1: Copyright [yyyy] [name of
copyright owner]
My bad, corrected the same with new patch.

On 2014/05/14 12:50:13, eseidel wrote:
> This looks wrong.

https://codereview.chromium.org/267423005/diff/1/LayoutTests/third_party/Noto...
File LayoutTests/third_party/NotoSans/README.txt (right):

https://codereview.chromium.org/267423005/diff/1/LayoutTests/third_party/Noto...
LayoutTests/third_party/NotoSans/README.txt:9: We publish our fonts under the
terms of the GPL (see GPL.txt) and OFL (OFL.txt)
Corrected the same with new patch.
On 2014/05/14 12:50:13, eseidel wrote:
> This does not agree with the license file you added.

[Dominik Röttsches, 2014-05-14 13:53:30]

What is the original source? 

I think the current source/upstream for the font you're looking at is from 
Google's Internationalisation team's: https://code.google.com/p/noto/

Looking at:
https://code.google.com/p/noto/source/browse/trunk/fonts/individual/

The LICENSE file there reproduces the full Apache license, I would copy that one
here then.

There is no README in the repository of that project.

So the README file should just be similar to the one for MEgalopolis (in the
same folder).

A name of the Font and project, and the reason why you're including it.

If there is an upstream README file, you should rename your additions to sth
like README.Chromium

[Dominik Röttsches, 2014-05-14 13:55:13]

> A	 LayoutTests/third_party/NotoSans/NotoSansDevanagari-Regular.ttf.subset

What's the source of this subset? Behdad's test page? We probably do not want to
fork the font here, but instead include the full NotoSansDevanagari-Regular.ttf
font.

[h.joshi, 2014-05-14 15:06:21]

subset font is of very small size while actual font will be heavy one that was
the reason to use subset font.
Will make change to include complete font and also changes to License and ReadMe
file.

[behdad_google, 2014-05-15 01:40:59]

The subset in question was created using the following command:

$ pyftsubset ./NotoSansDevanagari-Regular.ttf uni091D

where pyftsubset comes from https://github.com/behdad/fonttools

Possibly rename the font to either have the U091D in the name, or the bug or
test name / number.

[h.joshi, 2014-05-15 03:06:48]

Okey, will rename font name to "NotoSansDevanagari-Regular-uni091D.ttf"

[h.joshi, 2014-05-15 05:26:59]

New patch with comment fixes, PTAL

[Dominik Röttsches, 2014-05-15 10:26:59]

https://codereview.chromium.org/267423005/diff/40001/LayoutTests/third_party/...
File LayoutTests/third_party/NotoSans/README.txt (right):

https://codereview.chromium.org/267423005/diff/40001/LayoutTests/third_party/...
LayoutTests/third_party/NotoSans/README.txt:2: from
https://code.google.com/p/noto/source/browse/trunk/fonts/individual/
Okay, now I actually understood what you did. Let me clarify my earlier review:

By "a README like MEgalopolis" I did not mean that you should copy the README
file from there and string replace SMeltery with "Google Internationalisation
team", but to create a README that is conceptually the same, so it should
contain:

1) The origin/source/upstream project of the font
2) A rationale why you're including it
3) A short license information, something like "For license information, see the
LICENSE file." can be enough.

That's it. Now, let's wait for a discussion on blink-dev to see how we handle
derivative reduced fonts, as discussed on the other CL.

[h.joshi, 2014-05-15 11:03:23]

Okey, so in the previous patch (Patch set 2) I was just required to add source
location for fonts, other two points were already present.
 Will wait for blink-dev discussion outcome.

[Dirk Pranke, 2014-05-20 00:04:40]

Please include the pyftsubset command in the README; it should be possible to
determine from the README exactly where the font came from (which includes how
we subset it).

Otherwise, lgtm.

[h.joshi, 2014-05-20 04:35:45]

thank you, will include pyftsubset command in README and share new patch.

[h.joshi, 2014-05-20 06:58:53]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2014-05-20 06:59:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/h.joshi@samsung.com/267423005/80001

[commit-bot: I haz the power, 2014-05-20 08:15:27]

Change committed as 174351

[Dominik Röttsches, 2014-05-20 08:49:25]

https://codereview.chromium.org/267423005/diff/80001/LayoutTests/third_party/...
File LayoutTests/third_party/NotoSans/README.txt (right):

https://codereview.chromium.org/267423005/diff/80001/LayoutTests/third_party/...
LayoutTests/third_party/NotoSans/README.txt:16: $ pyftsubset
./NotoSansDevanagari-Regular.ttf <Unicode>
I believe Dirk meant the actual command here, not a placeholder for the
codepoint.

$ pyftsubset ./NotoSansDevanagari-Regular.ttf uni091D

(From Behdad's comment.)

Also, on blink-dev he recommends to call the file README.Chromium - but this may
not be as critical.

[h.joshi, 2014-05-20 08:54:22]

I thought we have to be generic in specifying the command for subset.

Will updating this patch work or I have to make a new patch submit
Pls Suggest.

[Dominik Röttsches, 2014-05-20 10:36:05]

On 2014/05/20 08:54:22, h.joshi wrote:
> I thought we have to be generic in specifying the command for subset.

The idea is to be able to reproduce the same result.

> Will updating this patch work or I have to make a new patch submit
> Pls Suggest.

It's not that critical, but if you wanna fix it, you'd make a new CL.

[Dirk Pranke, 2014-05-20 15:40:56]

Fixing the comments in a subsequent patch would be fine ...

https://codereview.chromium.org/267423005/diff/80001/LayoutTests/third_party/...
File LayoutTests/third_party/NotoSans/README.txt (right):

https://codereview.chromium.org/267423005/diff/80001/LayoutTests/third_party/...
LayoutTests/third_party/NotoSans/README.txt:16: $ pyftsubset
./NotoSansDevanagari-Regular.ttf <Unicode>
On 2014/05/20 08:49:25, Dominik Röttsches wrote:
> I believe Dirk meant the actual command here, not a placeholder for the
> codepoint.
> 
> $ pyftsubset ./NotoSansDevanagari-Regular.ttf uni091D
> 
> (From Behdad's comment.)
> 

Right.

> Also, on blink-dev he recommends to call the file README.Chromium - but this
may
> not be as critical.

Also, right. The general convention we use is README.chromium, so that it's
clear that this README is associated with instructions for Chromium devs, rather
than a README that might be carried over from the original project.