DescriptionRevert of Store and restore view focus in OnWindowFocused. (https://codereview.chromium.org/282223002/)
Reason for revert:
ConstrainedWindowViewTest.ClosesOnEscape introduced in this patch fails on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/31239/steps/interactive_ui_tests/logs/stdio
Original issue's description:
> Store and restore view focus in OnWindowFocused.
>
> Mimic [Desktop]NativeWidgetAura::OnWindowActivated.
> Simplify OnNativeBlur calls and OnNative[Blur|Focus] impls.
> (View focus changes update the TextInputClient as needed)
> Rewrite and enable related ConstrainedWindowViewTests.
>
> Print GetLastError() in SendInput() error case for tests.
> (key presses get 5/ERROR_ACCESS_DENIED on locked desktops?)
>
> BUG=368691, 170331, 177482, 163931
> TEST=Automated tests; the focused Views change as expected between the browser, web contents, and web content modal dialogs (print preview, collected cookies, etc.).
> R=sky@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271249
TBR=sky@chromium.org,msw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=368691, 170331, 177482, 163931
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271281
Patch Set 1 #
Created: 6 years, 7 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|