Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 289283003: Revert of Store and restore view focus in OnWindowFocused. (Closed)

Created:
6 years, 7 months ago by ckocagil
Modified:
6 years, 7 months ago
Reviewers:
msw, sky
CC:
chromium-reviews, tfarina, Ben Goodger (Google), tdanderson+views_chromium.org, Mike Wittman, Greg Billock
Visibility:
Public.

Description

Revert of Store and restore view focus in OnWindowFocused. (https://codereview.chromium.org/282223002/) Reason for revert: ConstrainedWindowViewTest.ClosesOnEscape introduced in this patch fails on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/31239/steps/interactive_ui_tests/logs/stdio Original issue's description: > Store and restore view focus in OnWindowFocused. > > Mimic [Desktop]NativeWidgetAura::OnWindowActivated. > Simplify OnNativeBlur calls and OnNative[Blur|Focus] impls. > (View focus changes update the TextInputClient as needed) > Rewrite and enable related ConstrainedWindowViewTests. > > Print GetLastError() in SendInput() error case for tests. > (key presses get 5/ERROR_ACCESS_DENIED on locked desktops?) > > BUG=368691, 170331, 177482, 163931 > TEST=Automated tests; the focused Views change as expected between the browser, web contents, and web content modal dialogs (print preview, collected cookies, etc.). > R=sky@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271249 TBR=sky@chromium.org,msw@chromium.org NOTREECHECKS=true NOTRY=true BUG=368691, 170331, 177482, 163931 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+441 lines, -178 lines) Patch
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 2 chunks +425 lines, -160 lines 0 comments Download
M ui/base/win/foreground_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 2 chunks +4 lines, -13 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ckocagil
Created Revert of Store and restore view focus in OnWindowFocused.
6 years, 7 months ago (2014-05-18 13:50:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/289283003/1
6 years, 7 months ago (2014-05-18 13:50:44 UTC) #2
commit-bot: I haz the power
Change committed as 271281
6 years, 7 months ago (2014-05-18 13:51:43 UTC) #3
msw
6 years, 7 months ago (2014-05-18 15:52:42 UTC) #4
Message was sent while issue was closed.
On 2014/05/18 13:51:43, I haz the power (commit-bot) wrote:
> Change committed as 271281

Dang, lgtm.

Powered by Google App Engine
This is Rietveld 408576698