Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 289283002: Add some layout tests about behavior on undefined and null. (Closed)

Created:
6 years, 7 months ago by zino
Modified:
6 years, 7 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add some layout tests about behavior on undefined and null. According to WebIDL in Blink guideline[1], behavior on undefind and null must be tested in layout tests. [1] http://www.chromium.org/blink/webidl#TOC-undefined-and-null Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174500

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -17 lines) Patch
M LayoutTests/fast/canvas/canvas-createImageData-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-currentTransform-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-isPointInPath-winding-expected.txt View 1 chunk +8 lines, -6 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-isPointInStroke-with-path-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-path-context-clip-expected.txt View 2 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-path-context-fill-expected.txt View 2 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-path-context-stroke-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-pattern-behaviour.js View 1 chunk +12 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-pattern-behaviour-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-putImageData.js View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-putImageData-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-scroll-path-into-view-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/canvas/drawImage-with-broken-image.html View 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/drawImage-with-broken-image-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-createImageData.js View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-currentTransform.js View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-isPointInStroke-with-path.js View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-path-context-clip.js View 2 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-path-context-fill.js View 2 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-path-context-stroke.js View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-scroll-path-into-view.js View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/virtual/gpu/fast/canvas/canvas-path-context-clip-expected.txt View 1 2 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/virtual/gpu/fast/canvas/canvas-path-context-fill-expected.txt View 1 2 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/virtual/gpu/fast/canvas/canvas-path-context-stroke-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
zino
Please take a look. Thank you.
6 years, 7 months ago (2014-05-18 07:15:06 UTC) #1
Justin Novosad
On 2014/05/18 07:15:06, zino wrote: > Please take a look. > > Thank you. lgtm
6 years, 7 months ago (2014-05-20 19:16:22 UTC) #2
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 7 months ago (2014-05-21 01:09:44 UTC) #3
zino
The CQ bit was unchecked by jinho.bang@samsung.com
6 years, 7 months ago (2014-05-21 01:09:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/289283002/1
6 years, 7 months ago (2014-05-21 01:10:10 UTC) #5
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 7 months ago (2014-05-21 03:39:27 UTC) #6
zino
The CQ bit was unchecked by jinho.bang@samsung.com
6 years, 7 months ago (2014-05-21 03:39:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/289283002/1
6 years, 7 months ago (2014-05-21 03:40:00 UTC) #8
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 7 months ago (2014-05-21 10:41:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/289283002/20001
6 years, 7 months ago (2014-05-21 10:42:58 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 01:14:36 UTC) #11
Message was sent while issue was closed. 
Change committed as 174500

Powered by Google App Engine
This is Rietveld 408576698