LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js - Issue 289283002: Add some layout tests about behavior on undefined and null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js

Issue 289283002: Add some layout tests about behavior on undefined and null. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/canvas/script-tests/canvas-currentTransform.js ('k') | LayoutTests/fast/canvas/script-tests/canvas-isPointInStroke-with-path.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js

diff --git a/LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js b/LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js

index 7ed85ecfe0782537222c13252e003101b5a02539..20c8a01186262f320a832f1b750afd472c1aad6b 100644

--- a/LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js

+++ b/LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js

@@ -61,17 +61,17 @@ function prepareTestScenario() {

shouldThrow("ctx.isPointInPath(50, 50, 'gazonk')");

debug('');

- debug('Testing null isPointInPath with Path object');

- path = null;

+ debug('Testing invalid type isPointInPath with Path object');

shouldThrow("ctx.isPointInPath(null, 50, 50)");

shouldThrow("ctx.isPointInPath(null, 50, 50, 'nonzero')");

shouldThrow("ctx.isPointInPath(null, 50, 50, 'evenodd')");

- shouldThrow("ctx.isPointInPath(path, 50, 50)");

- shouldThrow("ctx.isPointInPath(path, 50, 50, 'nonzero')");

- shouldThrow("ctx.isPointInPath(path, 50, 50, 'evenodd')");

- debug('');

- debug('Testing invalid type isPointInPath with Path object');

+ shouldThrow("ctx.isPointInPath(null, 50, 50, null)");

+ shouldThrow("ctx.isPointInPath(path, 50, 50, null)");

+ shouldThrow("ctx.isPointInPath(undefined, 50, 50)");

+ shouldThrow("ctx.isPointInPath(undefined, 50, 50, 'nonzero')");

+ shouldThrow("ctx.isPointInPath(undefined, 50, 50, 'evenodd')");

+ shouldThrow("ctx.isPointInPath(undefined, 50, 50, undefined)");

+ shouldThrow("ctx.isPointInPath(path, 50, 50, undefined)");

shouldThrow("ctx.isPointInPath([], 50, 50)");

shouldThrow("ctx.isPointInPath([], 50, 50, 'nonzero')");

shouldThrow("ctx.isPointInPath([], 50, 50, 'evenodd')");