Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2892813003:
Add MATCH_NUMBER to match types when parsing expiration date form field. (Closed)
|
Created:
3 years, 7 months ago by csashi Modified:
3 years, 7 months ago CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, Jared Saul Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd MATCH_NUMBER to match types when parsing expiration date form field.
BUG=724317
Review-Url: https://codereview.chromium.org/2892813003
Cr-Commit-Position: refs/heads/master@{#473664}
Committed: https://chromium.googlesource.com/chromium/src/+/0adcad330b0c78ec30e4f95e527e8ceff5ca749d
Patch Set 1 #Patch Set 2 : adds unit-test. #Patch Set 3 : adds unit-test. #
Messages
Total messages: 26 (20 generated)
csashi@google.com changed reviewers: + mathp@chromium.org, rogerm@chromium.org
Hi, Please take a look and let me know if this bug is worth fixing (false matches may outweigh true matches). Thanks! -sashi.
The CQ bit was checked by csashi@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I think it does, is there a test we can write for this?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by csashi@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/19 01:11:44, Mathieu wrote: > I think it does, is there a test we can write for this? Hi Mathieu, Please take a look. Thanks! -sashi.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by csashi@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by csashi@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
lgtm
The CQ bit was checked by csashi@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495478805072150,
"parent_rev": "a44af8f558766ab8c6b65fff8be4b1ef1a5f903b", "commit_rev":
"0adcad330b0c78ec30e4f95e527e8ceff5ca749d"}
Message was sent while issue was closed.
Description was changed from ========== Add MATCH_NUMBER to match types when parsing expiration date form field. BUG=724317 ========== to ========== Add MATCH_NUMBER to match types when parsing expiration date form field. BUG=724317 Review-Url: https://codereview.chromium.org/2892813003 Cr-Commit-Position: refs/heads/master@{#473664} Committed: https://chromium.googlesource.com/chromium/src/+/0adcad330b0c78ec30e4f95e527e... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/0adcad330b0c78ec30e4f95e527e... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
