Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2892753002:
Roll ICU to fd2abab8..c844075a (Closed)
|
Created:
3 years, 7 months ago by scottmg Modified:
3 years, 7 months ago Reviewers:
jungshik at Google CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll ICU to fd2abab8..c844075a
Only one change:
c844075 icu: Add defines for Fuchsia
TBR=jshin@chromium.org
BUG=706592
Review-Url: https://codereview.chromium.org/2892753002
Cr-Commit-Position: refs/heads/master@{#473018}
Committed: https://chromium.googlesource.com/chromium/src/+/c5ff6b33a647af9bcd5b2966fe94b912b215787b
Patch Set 1 #Messages
Total messages: 17 (12 generated)
Description was changed from ========== Roll ICU to c844075a c844075 icu: Add defines for Fuchsia BUG=760592 ========== to ========== Roll ICU to c844075a c844075 icu: Add defines for Fuchsia TBR=jshin@chromium.org BUG=760592 ==========
scottmg@chromium.org changed reviewers: + jshin@chromium.org
Description was changed from ========== Roll ICU to c844075a c844075 icu: Add defines for Fuchsia TBR=jshin@chromium.org BUG=760592 ========== to ========== Roll ICU to fd2abab8..c844075a Only one change: c844075 icu: Add defines for Fuchsia TBR=jshin@chromium.org BUG=760592 ==========
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll ICU to fd2abab8..c844075a Only one change: c844075 icu: Add defines for Fuchsia TBR=jshin@chromium.org BUG=760592 ========== to ========== Roll ICU to fd2abab8..c844075a Only one change: c844075 icu: Add defines for Fuchsia TBR=jshin@chromium.org BUG=706592 ==========
The CQ bit was unchecked by scottmg@chromium.org
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495149216654110, "parent_rev":
"cb4ae15478ddb2f45a6e306a3de4ff53b6b46269", "commit_rev":
"c5ff6b33a647af9bcd5b2966fe94b912b215787b"}
Message was sent while issue was closed.
Description was changed from ========== Roll ICU to fd2abab8..c844075a Only one change: c844075 icu: Add defines for Fuchsia TBR=jshin@chromium.org BUG=706592 ========== to ========== Roll ICU to fd2abab8..c844075a Only one change: c844075 icu: Add defines for Fuchsia TBR=jshin@chromium.org BUG=706592 Review-Url: https://codereview.chromium.org/2892753002 Cr-Commit-Position: refs/heads/master@{#473018} Committed: https://chromium.googlesource.com/chromium/src/+/c5ff6b33a647af9bcd5b2966fe94... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c5ff6b33a647af9bcd5b2966fe94... |
