Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2892733003: [Sensors] Cancel pending 'onchange' notifications (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by Mikhail
Modified:
2 months ago
CC:
chromium-reviews, haraken, blink-reviews, wanming.lin_intel.com, shalamov, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Cancel pending 'onchange' notifications The scheduled deferred 'onchange' notifications must be cancelled if the Sensor gets deactivated. Review-Url: https://codereview.chromium.org/2892733003 Cr-Commit-Position: refs/heads/master@{#473482} Committed: https://chromium.googlesource.com/chromium/src/+/0461d19b57461980dde77a7f4f5e5c3c80d4dc4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M third_party/WebKit/Source/modules/sensor/Sensor.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 5 chunks +13 lines, -11 lines 0 comments Download
Trybot results:  win_clang   win_chromium_rel_ng   win_chromium_x64_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios-simulator   ios-device-xcode-clang   ios-simulator-xcode-clang   ios-device   linux_chromium_rel_ng   linux_chromium_tsan_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_asan_rel_ng   chromium_presubmit   linux_chromium_chromeos_ozone_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   chromeos_daisy_chromium_compile_only_ng   cast_shell_linux   android_n5x_swarming_rel   cast_shell_android   linux_android_rel_ng   android_compile_dbg   android_cronet   android_clang_dbg_recipe   android_arm64_dbg_recipe   linux_chromium_chromeos_ozone_rel_ng   win_chromium_rel_ng   win_clang   win_chromium_x64_rel_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   win_chromium_rel_ng   win_chromium_compile_dbg_ng   ios-simulator-xcode-clang   ios-simulator   ios-device-xcode-clang   ios-device   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_asan_rel_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   cast_shell_linux   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_android   android_n5x_swarming_rel   linux_android_rel_ng   android_cronet   android_compile_dbg   android_clang_dbg_recipe   android_arm64_dbg_recipe 
Commit queue not available (can’t edit this change).

Messages

Total messages: 13 (8 generated)
Mikhail
PTAL
2 months ago (2017-05-19 11:07:31 UTC) #4
shalamov
lgtm
2 months ago (2017-05-19 11:32:51 UTC) #5
Reilly Grant (use Gerrit)
lgtm
2 months ago (2017-05-19 19:43:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892733003/1
2 months ago (2017-05-21 19:29:52 UTC) #10
commit-bot: I haz the power
2 months ago (2017-05-21 21:15:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0461d19b57461980dde77a7f4f5e...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973