Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1014)

Issue 2892733003: [Sensors] Cancel pending 'onchange' notifications (Closed)

Created:
11 months ago by Mikhail
Modified:
11 months ago
CC:
chromium-reviews, haraken, blink-reviews, wanming.lin_intel.com, shalamov, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Cancel pending 'onchange' notifications The scheduled deferred 'onchange' notifications must be cancelled if the Sensor gets deactivated. Review-Url: https://codereview.chromium.org/2892733003 Cr-Commit-Position: refs/heads/master@{#473482} Committed: https://chromium.googlesource.com/chromium/src/+/0461d19b57461980dde77a7f4f5e5c3c80d4dc4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M third_party/WebKit/Source/modules/sensor/Sensor.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 5 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Mikhail
PTAL
11 months ago (2017-05-19 11:07:31 UTC) #4
shalamov
lgtm
11 months ago (2017-05-19 11:32:51 UTC) #5
Reilly Grant (use Gerrit)
lgtm
11 months ago (2017-05-19 19:43:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892733003/1
11 months ago (2017-05-21 19:29:52 UTC) #10
commit-bot: I haz the power
11 months ago (2017-05-21 21:15:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0461d19b57461980dde77a7f4f5e...

Powered by Google App Engine
This is Rietveld 408576698