Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 2892703002: Finish ../platform => public/platform refactor (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, browser-components-watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, estade+watch_chromium.org, jam, mathp+autofillwatch_chromium.org, mlamouri+watch-content_chromium.org, rogerm+autofillwatch_chromium.org, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Finish ../platform => public/platform refactor In https://codereview.chromium.org/2887233003, I changed most of the header includes in the third_party/WebKit/public/web directory that started with "../platform/" to instead start with "public/platform/" in order to make these header includes valid under a DEPS rule that's flagging new includes of the form "../platform/" as errors. I did not change these headers in that CL because some build targets were not building properly. I've determined that the problem was that these targets are missing a dependency in their BUILD.gn files. This CL adds this dependency to those build files and finishes the codemod. Note: I have not run git cl format to put the headers in the correct order because I ran into problems with the original CL due to this breaking fragile code. BUG=724264 Review-Url: https://codereview.chromium.org/2892703002 Cr-Commit-Position: refs/heads/master@{#473333} Committed: https://chromium.googlesource.com/chromium/src/+/38a14eb81c041f7ae7bff36226318bca3d161e79

Patch Set 1 #

Patch Set 2 : Add more deps #

Patch Set 3 : Add another dep, use blink_headers instead of blink #

Patch Set 4 : Fix syntax error in chrome/browser/BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 3 chunks +3 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M headless/BUILD.gn View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebConsoleMessage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFormControlElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFormElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebNode.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebPrintParams.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 29 (25 generated)
rlanday
3 years, 7 months ago (2017-05-18 20:59:05 UTC) #20
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-19 13:35:16 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892703002/60001
3 years, 7 months ago (2017-05-19 20:07:35 UTC) #26
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 21:38:20 UTC) #29
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/38a14eb81c041f7ae7bff3622631...

Powered by Google App Engine
This is Rietveld 408576698