Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2892673002: [Home] Fix placeholder color for incognito (Closed)

Created:
3 years, 7 months ago by mdjones
Modified:
3 years, 7 months ago
Reviewers:
Ted C, Theresa
CC:
chromium-reviews, David Trainor- moved to gerrit, ntp-dev+reviews_chromium.org, tfarina, browser-components-watch_chromium.org, noyau+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Fix placeholder color for incognito Expanding the bottom sheet from the peeking state now uses the correct incognito default color. This change also introduces the concept of bottom sheet content having a normal or incognito theme which aids in making the transitions smooth. BUG=723888 Review-Url: https://codereview.chromium.org/2892673002 Cr-Commit-Position: refs/heads/master@{#474133} Committed: https://chromium.googlesource.com/chromium/src/+/f00f909143bb444b0fc887fff764f4e760a0147e

Patch Set 1 #

Messages

Total messages: 11 (5 generated)
mdjones
UX is still trying to figure out the color situation, but this is probably good ...
3 years, 7 months ago (2017-05-23 01:41:20 UTC) #2
Theresa
lgtm
3 years, 7 months ago (2017-05-23 14:49:03 UTC) #3
mdjones
+tedchoc for owners.
3 years, 7 months ago (2017-05-23 20:12:31 UTC) #5
Ted C
lgtm
3 years, 7 months ago (2017-05-23 20:13:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892673002/1
3 years, 7 months ago (2017-05-23 23:45:32 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 02:39:34 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f00f909143bb444b0fc887fff764...

Powered by Google App Engine
This is Rietveld 408576698