Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2892663003: [ObjC ARC] Converts ios/chrome/browser/browsing_data:browsing_data_internal to ARC. (Closed)

Created:
3 years, 7 months ago by liaoyuke
Modified:
3 years, 6 months ago
CC:
chromium-reviews, msramek+watch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, markusheintz_
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/browsing_data:browsing_data_internal to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2892663003 Cr-Commit-Position: refs/heads/master@{#477475} Committed: https://chromium.googlesource.com/chromium/src/+/981b6a8a907ce40b46fbe76881a0f0394cc00d2b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M ios/chrome/browser/browsing_data/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm View 10 chunks +19 lines, -17 lines 1 comment Download

Messages

Total messages: 15 (9 generated)
liaoyuke
Hi Rohit, PTAL. Thank you very much!
3 years, 6 months ago (2017-05-30 17:38:14 UTC) #6
rohitrao (ping after 24h)
+stk
3 years, 6 months ago (2017-06-01 17:30:06 UTC) #8
stkhapugin
lgtm
3 years, 6 months ago (2017-06-02 12:43:50 UTC) #9
rohitrao (ping after 24h)
lgtm https://codereview.chromium.org/2892663003/diff/1/ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm File ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm (right): https://codereview.chromium.org/2892663003/diff/1/ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm#newcode117 ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm:117: __weak id<BrowsingDataRemovalControllerDelegate> _delegate; Should this just become a ...
3 years, 6 months ago (2017-06-05 14:37:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892663003/1
3 years, 6 months ago (2017-06-06 22:34:24 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 00:12:40 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/981b6a8a907ce40b46fbe76881a0...

Powered by Google App Engine
This is Rietveld 408576698