Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2892663002: PPC/s390: Reland: [TypeFeedbackVector] Store optimized code in the vector (Closed)

Created:
3 years, 7 months ago by JaideepBajwa
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Reland: [TypeFeedbackVector] Store optimized code in the vector Port 11a211ff1b81e8d83d1aa4898743c2efb89603bd Port 663a8ef4706904c766852a0dc2a4acb6e57dbc4a Original Commit Message: Since the feedback vector is itself a native context structure, why not store optimized code for a function in there rather than in a map from native context to code? This allows us to get rid of the optimized code map in the SharedFunctionInfo, saving a pointer, and making lookup of any optimized code quicker. Original patch by Michael Stanton <mvstanton@chromium.org>; R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:6246, chromium:718891 LOG=N Review-Url: https://codereview.chromium.org/2892663002 Cr-Commit-Position: refs/heads/master@{#45385} Committed: https://chromium.googlesource.com/v8/v8/+/d4da5cb41fbd1c9ed88db54596cdd349aa5bbce9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -106 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 3 chunks +18 lines, -51 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 3 chunks +21 lines, -55 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
ptal
3 years, 7 months ago (2017-05-17 21:28:11 UTC) #1
john.yan
lgtm
3 years, 7 months ago (2017-05-17 21:29:16 UTC) #2
john.yan
lgtm
3 years, 7 months ago (2017-05-17 21:29:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892663002/1
3 years, 7 months ago (2017-05-17 21:30:27 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 22:12:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d4da5cb41fbd1c9ed88db54596cdd349aa5...

Powered by Google App Engine
This is Rietveld 408576698