Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: chrome/browser/resources/pdf/open_pdf_params_parser.js

Issue 2892623002: Type check PDF plugin JS code, down to 53 errors. (Closed)
Patch Set: Revert compiled_resources2.gyp for now. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/pdf/navigator.js ('k') | chrome/browser/resources/pdf/toolbar_manager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/pdf/open_pdf_params_parser.js
diff --git a/chrome/browser/resources/pdf/open_pdf_params_parser.js b/chrome/browser/resources/pdf/open_pdf_params_parser.js
index 00f44773f464287cb95ad7c2eb581bd19496d8c2..04eedf3da15f9222c5fdeaf18eca444c521a35c2 100644
--- a/chrome/browser/resources/pdf/open_pdf_params_parser.js
+++ b/chrome/browser/resources/pdf/open_pdf_params_parser.js
@@ -9,6 +9,7 @@
* passed in the url to set initial viewport settings for opening the pdf.
* @param {Object} getNamedDestinationsFunction The function called to fetch
* the page number for a named destination.
+ * @constructor
*/
function OpenPDFParamsParser(getNamedDestinationsFunction) {
this.outstandingRequests_ = [];
@@ -21,7 +22,7 @@ OpenPDFParamsParser.prototype = {
* Parse zoom parameter of open PDF parameters. If this
* parameter is passed while opening PDF then PDF should be opened
* at the specified zoom level.
- * @param {number} zoom value.
+ * @param {string} paramValue zoom value.
* @param {Object} viewportPosition to store zoom and position value.
*/
parseZoomParam_: function(paramValue, viewportPosition) {
@@ -112,7 +113,7 @@ OpenPDFParamsParser.prototype = {
if ('page' in paramsDictionary) {
// |pageNumber| is 1-based, but goToPage() take a zero-based page number.
- var pageNumber = parseInt(paramsDictionary['page']);
+ var pageNumber = parseInt(paramsDictionary['page'], 10);
if (!isNaN(pageNumber) && pageNumber > 0)
viewportPosition['page'] = pageNumber - 1;
}
« no previous file with comments | « chrome/browser/resources/pdf/navigator.js ('k') | chrome/browser/resources/pdf/toolbar_manager.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698