Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8663)

Unified Diff: chrome/browser/resources/pdf/navigator.js

Issue 2892623002: Type check PDF plugin JS code, down to 53 errors. (Closed)
Patch Set: Revert compiled_resources2.gyp for now. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/pdf/open_pdf_params_parser.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/pdf/navigator.js
diff --git a/chrome/browser/resources/pdf/navigator.js b/chrome/browser/resources/pdf/navigator.js
index 15c4518e1280ddaf907b0ba757c968e369dbaab9..d619c42a60ba96e9299d0d956390afc382b9b4d0 100644
--- a/chrome/browser/resources/pdf/navigator.js
+++ b/chrome/browser/resources/pdf/navigator.js
@@ -9,6 +9,7 @@
* do the actual navigating.
* @param {number} tabId The tab ID of the PDF viewer or -1 if the viewer is
* not displayed in a tab.
+ * @constructor
*/
function NavigatorDelegate(tabId) {
this.tabId_ = tabId;
@@ -22,6 +23,7 @@ function NavigatorDelegate(tabId) {
* @param {Object} navigatorDelegate The object with callback functions that
* get called when navigation happens in the current tab, a new tab,
* and a new window.
+ * @constructor
*/
function Navigator(originalUrl, viewport, paramsParser, navigatorDelegate) {
this.originalUrl_ = originalUrl;
@@ -91,7 +93,6 @@ Navigator.WindowOpenDisposition = {
Navigator.prototype = {
/**
- * @private
* Function to navigate to the given URL. This might involve navigating
* within the PDF page or opening a new url (in the same tab or a new tab).
* @param {string} url The URL to navigate to.
@@ -173,7 +174,7 @@ Navigator.prototype = {
/**
* @private
* Checks if the URL starts with a scheme and is not just a scheme.
- * @param {string} The input URL
+ * @param {string} url The input URL
* @return {boolean} Whether the url is valid.
*/
isValidUrl_: function(url) {
@@ -206,7 +207,7 @@ Navigator.prototype = {
/**
* @private
* Attempt to figure out what a URL is when there is no scheme.
- * @param {string} The input URL
+ * @param {string} url The input URL
* @return {string} The URL with a scheme or the original URL if it is not
* possible to determine the scheme.
*/
« no previous file with comments | « no previous file | chrome/browser/resources/pdf/open_pdf_params_parser.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698