Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2892583003: Use samedocument term instead of in-page in NavigationController test. (Closed)

Created:
3 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use same document term instead of in-page in NavigationController test. Old name was presumably used to match was_within_same_page IPC, but SameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with the rest of Chromium code. BUG=695189 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2892583003 Cr-Commit-Position: refs/heads/master@{#472599} Committed: https://chromium.googlesource.com/chromium/src/+/067c3b4f61f6f601a899043e91d3d25fe41997a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -89 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 58 chunks +95 lines, -89 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Eugene But (OOO till 7-30)
3 years, 7 months ago (2017-05-17 22:22:57 UTC) #6
Charlie Reis
LGTM
3 years, 7 months ago (2017-05-17 22:37:20 UTC) #7
Eugene But (OOO till 7-30)
Thanks for a quick review!
3 years, 7 months ago (2017-05-17 22:45:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892583003/1
3 years, 7 months ago (2017-05-17 22:46:28 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 23:24:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/067c3b4f61f6f601a899043e91d3...

Powered by Google App Engine
This is Rietveld 408576698