Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2892533003: [Payments] Reset card billing address when related profile is deleted. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by sebsg
Modified:
5 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Reset card billing address when related profile is deleted. BUG=723261 Review-Url: https://codereview.chromium.org/2892533003 Cr-Commit-Position: refs/heads/master@{#472552} Committed: https://chromium.googlesource.com/chromium/src/+/1fbb68b7dbf4977fce75ae74a8c1683ec26d5474

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added curly #

Messages

Total messages: 18 (11 generated)
sebsg
Hi Math, PTAL
5 months ago (2017-05-17 14:40:53 UTC) #6
Mathieu
lgtm https://codereview.chromium.org/2892533003/diff/1/components/autofill/core/browser/personal_data_manager.cc File components/autofill/core/browser/personal_data_manager.cc (right): https://codereview.chromium.org/2892533003/diff/1/components/autofill/core/browser/personal_data_manager.cc#newcode736 components/autofill/core/browser/personal_data_manager.cc:736: if (is_credit_card) add curlies
5 months ago (2017-05-17 15:55:32 UTC) #7
sebsg
Thanks sending to CQ https://codereview.chromium.org/2892533003/diff/1/components/autofill/core/browser/personal_data_manager.cc File components/autofill/core/browser/personal_data_manager.cc (right): https://codereview.chromium.org/2892533003/diff/1/components/autofill/core/browser/personal_data_manager.cc#newcode736 components/autofill/core/browser/personal_data_manager.cc:736: if (is_credit_card) On 2017/05/17 15:55:32, ...
5 months ago (2017-05-17 15:59:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892533003/20001
5 months ago (2017-05-17 15:59:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/447335) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
5 months ago (2017-05-17 18:49:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892533003/20001
5 months ago (2017-05-17 18:54:40 UTC) #15
commit-bot: I haz the power
5 months ago (2017-05-17 20:30:05 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1fbb68b7dbf4977fce75ae74a8c1...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa