Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2892533002: Add Missing Includes to mf_helpers.h (Closed)

Created:
3 years, 7 months ago by robliao
Modified:
3 years, 7 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Missing Includes to mf_helpers.h mf_helpers.h was previously relying on scoped_comptr.h for selected definitions. scoped_comptr.h in the future will not include base/logging.h and base/macros.h, breaking this file. BUG=638327 TBR=dalecurtis@chromium.org Trivial change. Review-Url: https://codereview.chromium.org/2892533002 Cr-Commit-Position: refs/heads/master@{#472482} Committed: https://chromium.googlesource.com/chromium/src/+/f7452d2eaafcf78e874f5f2eda336228e45f8d1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M media/base/win/mf_helpers.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
robliao
TBR'ing dalecurtis@chromium.org for this trivial change.
3 years, 7 months ago (2017-05-17 00:48:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892533002/1
3 years, 7 months ago (2017-05-17 00:48:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-17 02:50:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892533002/1
3 years, 7 months ago (2017-05-17 17:05:48 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 17:17:31 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f7452d2eaafcf78e874f5f2eda33...

Powered by Google App Engine
This is Rietveld 408576698