Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2892483004: Refactored out need to pass unresolved property id to ConsumePerspective (Closed)

Created:
3 years, 7 months ago by Bugs Nash
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactored out need to pass unresolved property id to ConsumePerspective BUG=668012 Review-Url: https://codereview.chromium.org/2892483004 Cr-Commit-Position: refs/heads/master@{#472946} Committed: https://chromium.googlesource.com/chromium/src/+/23cf82b8915a04b3c6c83717902b2bfe0c885dde

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Bugs Nash
3 years, 7 months ago (2017-05-18 01:24:52 UTC) #3
rjwright
On 2017/05/18 01:24:52, Bugs Nash wrote: lgtm
3 years, 7 months ago (2017-05-18 05:07:19 UTC) #7
Bugs Nash
+alancutter for owners
3 years, 7 months ago (2017-05-18 06:58:55 UTC) #9
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-18 07:23:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892483004/1
3 years, 7 months ago (2017-05-18 21:57:55 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 22:06:00 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/23cf82b8915a04b3c6c83717902b...

Powered by Google App Engine
This is Rietveld 408576698