Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2892473004:
[DevTools] continue-to-location prefers current frame (Closed)
|
Created:
3 years, 7 months ago by kozy Modified:
3 years, 7 months ago Reviewers:
dgozman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] continue-to-location prefers current frame
In case of recursion with new continue-to-location on ctrl click we'll break at current call frame instead of frame in recursion call.
BUG=v8:6397
R=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2892473004
Cr-Commit-Position: refs/heads/master@{#473147}
Committed: https://chromium.googlesource.com/chromium/src/+/890c278213ee759d9ac2063847168209c38c32e9
Patch Set 1 #
Total comments: 2
Messages
Total messages: 16 (9 generated)
Dmitry, please take a look!
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm https://codereview.chromium.org/2892473004/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js (right): https://codereview.chromium.org/2892473004/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js:1085: this.payload(), SDK.DebuggerModel.ContinueToLocationTargetCallFrames.Current); There is a Protocol.DebuggerAgent..... enum already.
https://codereview.chromium.org/2892473004/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js (right): https://codereview.chromium.org/2892473004/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js:1085: this.payload(), SDK.DebuggerModel.ContinueToLocationTargetCallFrames.Current); On 2017/05/18 21:50:32, dgozman wrote: > There is a Protocol.DebuggerAgent..... enum already. Acknowledged.
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495176334663440, "parent_rev":
"0bd3d49f9c5aa28cc95c175604883b57142f6ada", "commit_rev":
"890c278213ee759d9ac2063847168209c38c32e9"}
Message was sent while issue was closed.
Description was changed from ========== [DevTools] continue-to-location prefers current frame In case of recursion with new continue-to-location on ctrl click we'll break at current call frame instead of frame in recursion call. BUG=v8:6397 R=dgozman@chromium.org ========== to ========== [DevTools] continue-to-location prefers current frame In case of recursion with new continue-to-location on ctrl click we'll break at current call frame instead of frame in recursion call. BUG=v8:6397 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2892473004 Cr-Commit-Position: refs/heads/master@{#473147} Committed: https://chromium.googlesource.com/chromium/src/+/890c278213ee759d9ac206384716... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/890c278213ee759d9ac206384716... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
