Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2892473003: Upstream service worker "register" tests to WPT (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service worker "register" tests to WPT **register-default-scope** This test exists in both WPT and the Chromium project tree. Because they differ only in implementation details of the testing infrastructure, the Chromium-specific version may be removed without affecting test coverage in the Chromium project. **register-link-element** This test was previously re-located to the Web Platform Tests project [1], but its corresponding "expectations" file was mistakenly persisted. Remove that file. [1] See commit e46007715a723c2219f49db6199f1af09cbbc7db in the Chromium project **register-same-scope-different-script-url** This test exists in both WPT and the Chromium project tree. The WPT version is slightly weaker because it accounts for a condition that is not possible according to the latest version of the Service Workers specification [2]. > # Install > > [...] > > 17. Run the Update Registration State algorithm passing registration, > "installing" and null as the arguments. > 18. Run the Update Worker State algorithm passing registration’s > waiting worker and installed as the arguments. > 19. Invoke Finish Job with job. > 20. Wait for all the tasks queued by Update Worker State invoked in > this algorithm have executed. > 21. Invoke Try Activate with registration. Due to step 20, worker activation does not occur until all prior tasks (which includes microtasks such as the Promise handler microtask created in the test's body) have executed. Remove the conditional logic from the WPT version and remove the Chromium test file. [2] https://w3c.github.io/ServiceWorker/#installation-algorithm, retrieved on 2017-05-16 **register-wait-forever-in-install-worker** The Web Platform Tests project maintains a more rigorous version of this test, but because that version currently fails in Chromium, this version cannot be removed without negatively effecting test coverage. Re-name the test file and add an in-line comment to document the test's deprecated status. **register-foreign-fetch-error** Update URLs to suitable values for the Web Platform Tests project. BUG=688116, 723037 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2892473003 Cr-Commit-Position: refs/heads/master@{#472636} Committed: https://chromium.googlesource.com/chromium/src/+/9190eb27531ee100bcb83450c9c32c5568531afd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -522 lines) Patch
A third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/register-foreign-fetch-errors.https.html View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/register-same-scope-different-script-url.https.html View 1 chunk +4 lines, -11 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/register-foreign-fetch-errors-worker.js View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.register-wait-forever-in-install-worker.html View 1 chunk +4 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/register-default-scope.html View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/register-foreign-fetch-errors.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/register-link-element-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html View 1 chunk +0 lines, -233 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/register-wait-forever-in-install-worker.html View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/register-foreign-fetch-errors-worker.js View 1 chunk +0 lines, -134 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
mike3
Hey Matt, here's another batch of test migrations. Mind taking a look?
3 years, 7 months ago (2017-05-16 22:18:39 UTC) #2
falken
lgtm
3 years, 7 months ago (2017-05-17 07:59:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892473003/1
3 years, 7 months ago (2017-05-17 14:47:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/457393)
3 years, 7 months ago (2017-05-17 15:38:53 UTC) #7
mike3
On 2017/05/17 15:38:53, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 7 months ago (2017-05-17 15:47:12 UTC) #8
falken
On 2017/05/17 15:47:12, mike3 wrote: > On 2017/05/17 15:38:53, commit-bot: I haz the power wrote: ...
3 years, 7 months ago (2017-05-18 01:25:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892473003/1
3 years, 7 months ago (2017-05-18 01:28:21 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 03:30:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9190eb27531ee100bcb83450c9c3...

Powered by Google App Engine
This is Rietveld 408576698