Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2892423002: Add nogncheck to OS_CHROMEOS-guarded #include from r472400. (Closed)

Created:
3 years, 7 months ago by tapted
Modified:
3 years, 7 months ago
Reviewers:
afakhry, Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add nogncheck to OS_CHROMEOS-guarded #include from r472400. gn check doesn't understand preprocessor directives. Currently a failure results on the Ozone FYI builders. BUG=722811 TBR=afakhry@chromium.org, dbeam@chromium.org Review-Url: https://codereview.chromium.org/2892423002 Cr-Commit-Position: refs/heads/master@{#473501} Committed: https://chromium.googlesource.com/chromium/src/+/6510e3d00f827f2f071d333a47a560fa9fe41dbf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (6 generated)
tapted
3 years, 7 months ago (2017-05-22 03:27:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892423002/1
3 years, 7 months ago (2017-05-22 03:28:10 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 04:06:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6510e3d00f827f2f071d333a47a5...

Powered by Google App Engine
This is Rietveld 408576698