Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2892403003: Simplify image decoder selection. (Closed)

Created:
3 years, 7 months ago by naga
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify image decoder selection. Simplify the image decoder selection by removing SniffResult. This avoids two levels of condition check to select image decoders. BUG=None Review-Url: https://codereview.chromium.org/2892403003 Cr-Commit-Position: refs/heads/master@{#475446} Committed: https://chromium.googlesource.com/chromium/src/+/aa263e32cadf984c2c77ea31a45d7bf39f14d8fc

Patch Set 1 #

Total comments: 3

Patch Set 2 : y #

Total comments: 5

Patch Set 3 : y #

Patch Set 4 : y #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -57 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp View 1 2 3 4 chunks +21 lines, -53 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
Shanmuga Pandi
https://codereview.chromium.org/2892403003/diff/1/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp (right): https://codereview.chromium.org/2892403003/diff/1/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp#newcode88 third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp:88: const char* contents = DetermineImageType is Dchecking the length, ...
3 years, 7 months ago (2017-05-22 09:57:30 UTC) #3
Srirama
On 2017/05/22 09:57:30, Shanmuga Pandi wrote: > https://codereview.chromium.org/2892403003/diff/1/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp > File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp (right): > > https://codereview.chromium.org/2892403003/diff/1/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp#newcode88 ...
3 years, 7 months ago (2017-05-22 10:08:25 UTC) #4
Shanmuga Pandi
https://codereview.chromium.org/2892403003/diff/1/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp (right): https://codereview.chromium.org/2892403003/diff/1/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp#newcode88 third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp:88: const char* contents = On 2017/05/22 09:57:30, Shanmuga Pandi ...
3 years, 7 months ago (2017-05-22 10:08:26 UTC) #5
naga
https://codereview.chromium.org/2892403003/diff/1/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp (right): https://codereview.chromium.org/2892403003/diff/1/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp#newcode88 third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp:88: const char* contents = On 2017/05/22 09:57:30, Shanmuga Pandi ...
3 years, 7 months ago (2017-05-22 10:11:49 UTC) #6
naga
3 years, 7 months ago (2017-05-23 00:27:19 UTC) #9
scroggo_chromium
Digging into the history a bit here: https://codereview.chromium.org/2173873003 introduced the SniffResult, to distinguish between an ...
3 years, 7 months ago (2017-05-23 15:18:21 UTC) #12
Noel Gordon
LGTM - with nits https://codereview.chromium.org/2892403003/diff/20001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp (right): https://codereview.chromium.org/2892403003/diff/20001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp#newcode66 third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp:66: // This needs to be ...
3 years, 7 months ago (2017-05-27 03:51:10 UTC) #13
naga
I will update the patch based on review comments https://codereview.chromium.org/2892403003/diff/20001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp (right): https://codereview.chromium.org/2892403003/diff/20001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp#newcode66 third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp:66: ...
3 years, 6 months ago (2017-05-29 05:39:56 UTC) #14
Noel Gordon
https://codereview.chromium.org/2892403003/diff/20001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp (right): https://codereview.chromium.org/2892403003/diff/20001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp#newcode66 third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp:66: // This needs to be updated if we ever ...
3 years, 6 months ago (2017-05-29 05:43:51 UTC) #15
naga
On 2017/05/29 05:43:51, noel gordon wrote: > https://codereview.chromium.org/2892403003/diff/20001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp > File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp (right): > > https://codereview.chromium.org/2892403003/diff/20001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp#newcode66 ...
3 years, 6 months ago (2017-05-29 05:46:58 UTC) #16
Noel Gordon
On 2017/05/29 05:46:58, naga wrote: > On 2017/05/29 05:43:51, noel gordon wrote: > > > ...
3 years, 6 months ago (2017-05-29 06:48:39 UTC) #17
naga
On 2017/05/29 06:48:39, noel gordon wrote: > On 2017/05/29 05:46:58, naga wrote: > > On ...
3 years, 6 months ago (2017-05-29 06:58:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892403003/60001
3 years, 6 months ago (2017-05-30 04:51:01 UTC) #23
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 06:49:07 UTC) #26
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/aa263e32cadf984c2c77ea31a45d...

Powered by Google App Engine
This is Rietveld 408576698