Move WebInputMethodControllerImpl to core/exported/ & break dependencies.

Move WebInputMethodControllerImpl to core/exported/ & break dependencies.

It turns out that WebInputMethodControllerImpl does not define any additional 
methods over WebInputMethodController, so in general we can change all of the
usage to the abstract class.

WebInputMethodControllerImpl::FromFrame is just a wrapper around WebLocalFrameBase
so removed that method and just call GetWebInputMethodController on 
WebLocalFameBase instead.

Also, move WebInputMethodControllerImpl to core/exported/ as is implements the
public GetWebInputMethodController.

BUG=712963
Review-Url: https://codereview.chromium.org/2892393002
Cr-Commit-Position: refs/heads/master@{#475296}
Committed: https://chromium.googlesource.com/chromium/src/+/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4

[slangley, 2017-05-22 02:11:05]

Description was changed from

==========
Fixup WebInputMethodControllerImpl.

BUG=
==========

to

==========
Move WebInputMethodControllerImpl to core/exported/ & break dependencies.

It turns out that WebInputMethodControllerImpl does not define any additional 
methods over WebInputMethodController, so in general we can change all of the
usage to the abstract class.

WebInputMethodControllerImpl::FromFrame is just a wrapper around
WebLocalFrameBase
so removed that method and just call GetWebInputMethodController on 
WebLocalFameBase instead.

Also, move WebInputMethodControllerImpl to core/exported/ as is implements the
public GetWebInputMethodController.

BUG=712963
==========

[slangley, 2017-05-22 02:11:05]

slangley@chromium.org changed reviewers:
+ nverne@chromium.org

[slangley, 2017-05-23 01:36:37]

slangley@chromium.org changed reviewers:
+ tkent@chromium.org

[dcheng, 2017-05-23 01:43:30]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2017-05-23 01:43:31]

https://codereview.chromium.org/2892393002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.h
(right):

https://codereview.chromium.org/2892393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.h:52:
WeakMember<WebLocalFrameBase> web_local_frame_;
FYI, I just changed this in https://chromium-review.googlesource.com/c/509149/
so you might have to rebase. Sorry!

[tkent, 2017-05-23 01:52:10]

lgtm

[nverne, 2017-05-23 04:05:08]

lgtm

[slangley, 2017-05-29 00:56:10]

The CQ bit was checked by slangley@chromium.org

[slangley, 2017-05-29 00:56:11]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
nverne@chromium.org
Link to the patchset: https://codereview.chromium.org/2892393002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-05-29 00:56:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 02:10:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 02:10:46]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[slangley, 2017-05-29 02:59:18]

The CQ bit was checked by slangley@chromium.org

[slangley, 2017-05-29 02:59:18]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
nverne@chromium.org
Link to the patchset: https://codereview.chromium.org/2892393002/#ps60001
(title: "Make WebInputMethodController NON_EXPORTED_BASE.")

[commit-bot: I haz the power, 2017-05-29 02:59:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 03:11:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 03:11:53]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[slangley, 2017-05-29 04:12:00]

The CQ bit was checked by slangley@chromium.org

[slangley, 2017-05-29 04:12:00]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
nverne@chromium.org
Link to the patchset: https://codereview.chromium.org/2892393002/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-05-29 04:12:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 05:58:21]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496031120249240,
"parent_rev": "cd04968d5279e7797fe9d2a159881860c5e45985", "commit_rev":
"7c9f28d128319e9d3f534440143ab8f1eeb2e3c4"}

[commit-bot: I haz the power, 2017-05-29 05:58:32]

Description was changed from

==========
Move WebInputMethodControllerImpl to core/exported/ & break dependencies.

It turns out that WebInputMethodControllerImpl does not define any additional 
methods over WebInputMethodController, so in general we can change all of the
usage to the abstract class.

WebInputMethodControllerImpl::FromFrame is just a wrapper around
WebLocalFrameBase
so removed that method and just call GetWebInputMethodController on 
WebLocalFameBase instead.

Also, move WebInputMethodControllerImpl to core/exported/ as is implements the
public GetWebInputMethodController.

BUG=712963
==========

to

==========
Move WebInputMethodControllerImpl to core/exported/ & break dependencies.

It turns out that WebInputMethodControllerImpl does not define any additional 
methods over WebInputMethodController, so in general we can change all of the
usage to the abstract class.

WebInputMethodControllerImpl::FromFrame is just a wrapper around
WebLocalFrameBase
so removed that method and just call GetWebInputMethodController on 
WebLocalFameBase instead.

Also, move WebInputMethodControllerImpl to core/exported/ as is implements the
public GetWebInputMethodController.

BUG=712963

Review-Url: https://codereview.chromium.org/2892393002
Cr-Commit-Position: refs/heads/master@{#475296}
Committed:
https://chromium.googlesource.com/chromium/src/+/7c9f28d128319e9d3f534440143a...
==========

[commit-bot: I haz the power, 2017-05-29 05:58:33]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7c9f28d128319e9d3f534440143a...