Do not include x11 files in case of Ozone builds

Do not include x11 files in case of Ozone builds

This only fails when no X11 headers are present on the system and

  use_ozone = true
  ozone_platform_wayland = true
  ozone_platform_x11 = false
  use_sysroot = false

BUG=295089
Review-Url: https://codereview.chromium.org/2892343002
Cr-Commit-Position: refs/heads/master@{#473718}
Committed: https://chromium.googlesource.com/chromium/src/+/c8de6a53455b05558640d3a658fd0b874dfe8e6e

[tonikitoo, 2017-05-20 15:24:56]

Description was changed from

==========
Do not include x11 files in case of Ozone builds

This only fails when no X11 headers are present on the system.

e.g.:
  use_ozone = true
  ozone_platform_wayland = true
  ozone_platform_x11 = false
  use_sysroot = false

BUG=295089
==========

to

==========
Do not include x11 files in case of Ozone builds

This only fails when no X11 headers are present on the system and

  use_ozone = true
  ozone_platform_wayland = true
  ozone_platform_x11 = false
  use_sysroot = false

BUG=295089
==========

[tonikitoo, 2017-05-20 15:24:56]

tonikitoo@igalia.com changed reviewers:
+ thestig@chromium.org

[tonikitoo, 2017-05-20 15:25:09]

ptal

[tonikitoo, 2017-05-20 17:05:27]

The CQ bit was checked by tonikitoo@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-20 17:05:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 17:47:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 17:47:58]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-05-22 18:20:12]

LGTM either as is or with my suggestion.

https://codereview.chromium.org/2892343002/diff/1/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_frame.cc (right):

https://codereview.chromium.org/2892343002/diff/1/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_frame.cc:43: #if defined(OS_LINUX) &&
!defined(OS_CHROMEOS) && !defined(USE_OZONE)
How about just if defined(USE_X11) ?

[tonikitoo, 2017-05-22 21:13:34]

On 2017/05/22 18:20:12, Lei Zhang wrote:
> LGTM either as is or with my suggestion.
> 
>
https://codereview.chromium.org/2892343002/diff/1/chrome/browser/ui/views/fra...
> File chrome/browser/ui/views/frame/browser_frame.cc (right):
> 
>
https://codereview.chromium.org/2892343002/diff/1/chrome/browser/ui/views/fra...
> chrome/browser/ui/views/frame/browser_frame.cc:43: #if defined(OS_LINUX) &&
> !defined(OS_CHROMEOS) && !defined(USE_OZONE)
> How about just if defined(USE_X11) ?

Suggestion taken, thanks.

[tonikitoo, 2017-05-22 21:13:53]

The CQ bit was checked by tonikitoo@igalia.com

[tonikitoo, 2017-05-22 21:13:53]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2892343002/#ps20001
(title: "Do not include x11 files in case of Ozone builds")

[commit-bot: I haz the power, 2017-05-22 21:14:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 22:01:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495487633334710,
"parent_rev": "6cfe5c7f23e1447422a21ddc7b6aa597a0e7021a", "commit_rev":
"c8de6a53455b05558640d3a658fd0b874dfe8e6e"}

[commit-bot: I haz the power, 2017-05-22 22:01:48]

Description was changed from

==========
Do not include x11 files in case of Ozone builds

This only fails when no X11 headers are present on the system and

  use_ozone = true
  ozone_platform_wayland = true
  ozone_platform_x11 = false
  use_sysroot = false

BUG=295089
==========

to

==========
Do not include x11 files in case of Ozone builds

This only fails when no X11 headers are present on the system and

  use_ozone = true
  ozone_platform_wayland = true
  ozone_platform_x11 = false
  use_sysroot = false

BUG=295089

Review-Url: https://codereview.chromium.org/2892343002
Cr-Commit-Position: refs/heads/master@{#473718}
Committed:
https://chromium.googlesource.com/chromium/src/+/c8de6a53455b05558640d3a658fd...
==========

[commit-bot: I haz the power, 2017-05-22 22:01:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c8de6a53455b05558640d3a658fd...