Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 2892303002: [Chromedriver] Disable testIFrameWithExtensionsSource on HEAD. (Closed)

Created:
3 years, 7 months ago by gmanikpure
Modified:
3 years, 7 months ago
Reviewers:
johnchen, stgao
CC:
chromium-reviews, johnchen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromedriver] Disable testIFrameWithExtensionsSource on HEAD. BUG=chromedriver:1819 Review-Url: https://codereview.chromium.org/2892303002 Cr-Commit-Position: refs/heads/master@{#473603} Committed: https://chromium.googlesource.com/chromium/src/+/571564116da46b3dcd202f9d03c3de41457a9f46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
gmanikpure
This test, introduced in crrev.com/473327 to fix issue#1777, started failing again on Chromium HEAD. Hence, ...
3 years, 7 months ago (2017-05-19 23:37:37 UTC) #2
johnchen
lgtm
3 years, 7 months ago (2017-05-20 20:35:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892303002/1
3 years, 7 months ago (2017-05-21 03:24:35 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-21 03:24:36 UTC) #7
stgao
lgtm
3 years, 7 months ago (2017-05-22 06:18:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892303002/1
3 years, 7 months ago (2017-05-22 16:47:44 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 17:03:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/571564116da46b3dcd202f9d03c3...

Powered by Google App Engine
This is Rietveld 408576698